Page MenuHomePhabricator
Create Task
Maniphest T297298

Remove scrubWikitext as an option
Open, MediumPublic
Actions

Description

Maintaining this as optional is not providing any tangible benefits but has real costs to developer overhead. So, these normalizations will just always be enabled.

Two steps to be taken,

  1. Remove the flag from the code (I5de9e42ab0dd36a751c19e06dc42403bd7c7ada7)
  2. Now that we're always guaranteed to be serializing from a normalized form, we can eliminate some of the wikitext escaping that proves impossible to generate.

A third step could be to get clients to stop passing the flag, as a cleanup.

Details

SubjectRepoBranchLines +/-
Stop passing scrub_wikitextmediawiki/extensions/VisualEditormaster+1 -1
Bump wikimedia/parsoid to 0.15.0-a14mediawiki/vendormaster+1 K -1 K
Remove scrubWikitext as an optionmediawiki/services/parsoidmaster+342 -720
Customize query in gerrit

Event Timeline

Arlolra created this task.Dec 8 2021, 4:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 8 2021, 4:01 PM
Arlolra triaged this task as Medium priority.Dec 8 2021, 4:01 PM
Arlolra moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.
gerritbot added a comment.Dec 8 2021, 4:01 PM

Change 739961 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Remove scrubWikitext as an option

https://gerrit.wikimedia.org/r/739961

gerritbot added a project: Patch-For-Review.Dec 8 2021, 4:01 PM
gerritbot added a comment.Dec 17 2021, 10:02 PM

Change 739961 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Remove scrubWikitext as an option

https://gerrit.wikimedia.org/r/739961

Maintenance_bot removed a project: Patch-For-Review.Dec 17 2021, 10:10 PM
Arlolra updated the task description. (Show Details)Dec 17 2021, 10:46 PM
Esanders subscribed.Jan 10 2022, 12:33 PM
gerritbot added a comment.Jan 10 2022, 6:00 PM

Change 752716 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a14

https://gerrit.wikimedia.org/r/752716

gerritbot added a project: Patch-For-Review.Jan 10 2022, 6:00 PM
gerritbot added a comment.Jan 10 2022, 7:38 PM

Change 752716 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a14

https://gerrit.wikimedia.org/r/752716

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2022, 8:10 PM
gerritbot added a comment.May 17 2022, 11:52 PM

Change 792742 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/VisualEditor@master] Stop passing scrub_wikitext

https://gerrit.wikimedia.org/r/792742

gerritbot added a project: Patch-For-Review.May 17 2022, 11:52 PM
gerritbot added a comment.May 18 2022, 11:41 PM

Change 792742 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Stop passing scrub_wikitext

https://gerrit.wikimedia.org/r/792742

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.13; 2022-05-23).May 19 2022, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 19 2022, 12:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL