Page MenuHomePhabricator

Wikilinks in <tr>-like wikitext attribute position are lost
Closed, ResolvedPublicBUG REPORT

Description

[subbu@earth:~/work/wmf/parsoid] echo "|--[[Foo]]" | php bin/parse.php
<p data-parsoid='{"dsr":[0,10,0,0]}'>|--<wikilink data-parsoid='{"src":"[[Foo]]","a":{"href":null},"sa":{"href":"Foo"},"dsr":[3,10,null,null]}'></wikilink></p>

This is because the TokenStreamPatcher runs after WikilinkHandler and so after the tr-contents are re-tokenized, it doesn't quite get processed till end of stage 2. This somehow feels like a known bug but something we haven't addressed yet, but this is a blocker for Parsoid Read Views.

Encountered on frwiki:Sauropsida

Event Timeline

ssastry triaged this task as Medium priority.

Change 749765 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TSP: Process retokenized tokens through stages 1 & 2

https://gerrit.wikimedia.org/r/749765

ssastry renamed this task from Wikilinks in <tr>-like wikitext attribute position is lost to Wikilinks in <tr>-like wikitext attribute position are lost.Dec 23 2021, 7:27 PM

Change 749765 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TSP: Process retokenized tokens through TTM stages 1 & 2

https://gerrit.wikimedia.org/r/749765

Change 752716 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a14

https://gerrit.wikimedia.org/r/752716

Change 752716 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.15.0-a14

https://gerrit.wikimedia.org/r/752716