Page MenuHomePhabricator

MultilineTextInputWidget with autosize=true grows too early
Closed, ResolvedPublic

Assigned To
Authored By
Esanders
Dec 17 2021, 5:23 PM
Referenced Files
F34887622: image.png
Dec 17 2021, 5:25 PM
F34887620: image.png
Dec 17 2021, 5:23 PM
F34887618: image.png
Dec 17 2021, 5:23 PM
Subscribers

Description

This widget has grown to three lines:

image.png (106×713 px, 16 KB)

even though there is room for more characters on line 2

image.png (108×711 px, 16 KB)

Event Timeline

Pausing in the debugger, the clone textarea being used to measure the height has scrollbars:

image.png (142×722 px, 27 KB)

Change 748170 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] MultilineTextInputWidget autosize: Exclude scrollbars when calculating new size

https://gerrit.wikimedia.org/r/748170

Change 748170 merged by jenkins-bot:

[oojs/ui@master] MultilineTextInputWidget autosize: Exclude scrollbars when calculating new size

https://gerrit.wikimedia.org/r/748170

Volker_E assigned this task to Esanders.
Volker_E triaged this task as Low priority.
Volker_E moved this task from Backlog to OOUI-0.43.0 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.43.0); removed OOUI.

Change 753557 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.43.0

https://gerrit.wikimedia.org/r/753557

Change 753557 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.43.0

https://gerrit.wikimedia.org/r/753557