TableFixups getting tripped up on pipe entities
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Jan 5 2022, 11:39 PM

Description

See the discussion in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/751467/1/src/Wt2Html/PP/Handlers/TableFixups.php#b276 from I0e57633b41796661565a7beb46e3309b5b0b8415

An example could be,

{|
|{{1x|test &#124; 123}} 456
|}

which is parsed as,

<table>
<tbody><tr>
<td>test &#124; 123 456
</td></tr></tbody></table>
<p><br />

<table data-parsoid='{"dsr":[0,33,2,2]}'>
<tbody data-parsoid='{"dsr":[3,31,0,0]}'><tr data-parsoid='{"autoInsertedStart":true,"dsr":[3,30,0,0]}'><td typeof="mw:Transclusion" about="#mwt1" data-parsoid='{"dsr":[3,30,1,0,1,0],"pi":[[{"k":"1"}]]}' data-mw='{"parts":["|",{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"test &amp;#124; 123"}},"i":0}}," 456"]}'>123 456</td></tr>
</tbody></table>

Details

	Subject	Repo	Branch	Lines +/-
	TableFixups: Minor perf tweaks and cleanup	mediawiki/services/parsoid	master	+24 -27

Customize query in gerrit

Event Timeline

Arlolra created this task.Jan 5 2022, 11:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2022, 11:39 PM

Arlolra triaged this task as Medium priority.Jan 5 2022, 11:41 PM

Arlolra added a project: Parsoid.

Arlolra updated the task description. (Show Details)

Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Change 751467 had a related patch set uploaded (by Arlolra; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TableFixups: Minor perf tweaks and cleanup

https://gerrit.wikimedia.org/r/751467

gerritbot added a project: Patch-For-Review.Jan 5 2022, 11:42 PM

Change 751467 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TableFixups: Minor perf tweaks and cleanup

https://gerrit.wikimedia.org/r/751467

Maintenance_bot removed a project: Patch-For-Review.Jan 6 2022, 1:10 AM

ssastry added a project: Parsoid-Read-Views.Feb 8 2022, 10:11 PM

ssastry moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Jun 14 2022, 11:02 PM

ssastry edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.

ssastry moved this task from Backlog to Mostly edge cases on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jun 14 2022, 11:05 PM

Looks fixed at this time.

<table data-parsoid='{"dsr":[0,33,2,2]}'>
<tbody data-parsoid='{"dsr":[3,31,0,0]}'><tr data-parsoid='{"autoInsertedStart":true,"dsr":[3,30,0,0]}'><td data-parsoid='{"dsr":[3,30,1,0]}'><span about="#mwt1" typeof="mw:Transclusion" data-parsoid='{"pi":[[{"k":"1"}]],"dsr":[4,26,null,null]}' data-mw='{"parts":[{"template":{"target":{"wt":"1x","href":"./Template:1x"},"params":{"1":{"wt":"test &amp;#124; 123"}},"i":0}}]}'>test </span><span typeof="mw:Entity" about="#mwt1">|</span><span about="#mwt1"> 123</span> 456</td></tr>
</tbody></table>

TableFixups getting tripped up on pipe entitiesClosed, ResolvedPublicActions

Description

Details

Event Timeline

TableFixups getting tripped up on pipe entities
Closed, ResolvedPublic
Actions