Page MenuHomePhabricator
Create Task
Maniphest T299303

Changing content model of a gadget definition page gives an internal error: Exception: Tried to save non-GadgetDefinitionContent
Closed, ResolvedPublic
Actions

Description

[322769faea345c08bf13fac0] /index.php/Special:ChangeContentModel/Gadget_definition:Foobar Exception: Tried to save non-GadgetDefinitionContent to Gadget definition:Foobar

Deliberately being thrown in GadgetHooks::onEditFilterMergedContent (though with // this should not be possible? comment which indicates invocation via ChangeContentModel may have been overlooked).

Details

SubjectRepoBranchLines +/-
Avoid raising exception while trying to change content model of gadget definitionmediawiki/extensions/GadgetsREL1_37+18 -21
Avoid raising exception while trying to change content model of gadget definitionmediawiki/extensions/Gadgetsmaster+18 -21
Customize query in gerrit

Event Timeline

SD0001 created this task.Jan 16 2022, 8:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2022, 8:49 AM
Aklapper renamed this task from Changing content model of a gadget definition page gives an internal error to Changing content model of a gadget definition page gives an internal error: Exception: Tried to save non-GadgetDefinitionContent.Jan 16 2022, 10:31 AM
gerritbot added a comment.Jan 16 2022, 5:15 PM

Change 754108 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/Gadgets@master] Avoid raising exception while trying to change content model of gadget definition

https://gerrit.wikimedia.org/r/754108

gerritbot added a project: Patch-For-Review.Jan 16 2022, 5:15 PM
gerritbot added a comment.Jan 18 2022, 9:18 PM

Change 754108 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Avoid raising exception while trying to change content model of gadget definition

https://gerrit.wikimedia.org/r/754108

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 18 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2022, 10:10 PM
gerritbot added a comment.Jan 27 2022, 6:19 AM

Change 757474 had a related patch set uploaded (by Ammarpad; author: SD0001):

[mediawiki/extensions/Gadgets@REL1_37] Avoid raising exception while trying to change content model of gadget definition

https://gerrit.wikimedia.org/r/757474

gerritbot added a project: Patch-For-Review.Jan 27 2022, 6:19 AM
gerritbot added a comment.Jan 27 2022, 6:35 AM

Change 757474 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@REL1_37] Avoid raising exception while trying to change content model of gadget definition

https://gerrit.wikimedia.org/r/757474

Ammarpad closed this task as Resolved.Jan 27 2022, 6:36 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 27 2022, 7:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL