Page MenuHomePhabricator
Create Task
Maniphest T299457

Unexpanded tokens occasionally make it to the HTML5 tree builder stage that cause crashers downstream
Closed, ResolvedPublic
Actions

Description

T299454 and T299185 are examples of production crashers that are a result of this underlying problem in the wt2html pipeline that needs to be investigate and fixed.

Details

SubjectRepoBranchLines +/-
Bump Parsoid to 0.15.0-a17mediawiki/vendormaster+170 -97
WikiLinkHandler: Reprocess incorrect tokens to the right stagemediawiki/services/parsoidmaster+29 -19
Customize query in gerrit

Related Objects

Event Timeline

ssastry triaged this task as Medium priority.Jan 18 2022, 9:52 PM
ssastry created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2022, 9:52 PM
ssastry claimed this task.Jan 18 2022, 10:51 PM
gerritbot added a comment.Jan 18 2022, 11:18 PM

Change 755039 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] WIP: Ensure tokens are always fully processed

https://gerrit.wikimedia.org/r/755039

gerritbot added a project: Patch-For-Review.Jan 18 2022, 11:18 PM
Reedy added a project: Parsoid.Jan 19 2022, 11:26 AM
gerritbot added a comment.Jan 23 2022, 7:18 PM

Change 755039 merged by jenkins-bot:

[mediawiki/services/parsoid@master] WikiLinkHandler: Reprocess incorrect tokens to the right stage

https://gerrit.wikimedia.org/r/755039

Maintenance_bot removed a project: Patch-For-Review.Jan 23 2022, 8:10 PM
gerritbot added a comment.Jan 24 2022, 5:29 PM

Change 756638 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a17

https://gerrit.wikimedia.org/r/756638

gerritbot added a project: Patch-For-Review.Jan 24 2022, 5:29 PM
gerritbot added a comment.Jan 24 2022, 8:09 PM

Change 756638 merged by jenkins-bot:

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a17

https://gerrit.wikimedia.org/r/756638

Maintenance_bot removed a project: Patch-For-Review.Jan 24 2022, 8:12 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 24 2022, 9:00 PM
ssastry closed this task as Resolved.Jan 25 2022, 6:17 PM
ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Going to close this. If any other instances of this shows up, we can reopen.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits