Page MenuHomePhabricator
Create Task
Maniphest T299615

Deprecate and remove onPagedTiffHandlerRenderCommand hook which uses raw shell commands
Closed, ResolvedPublic
Actions

Description

Seems it was never used for anything.

It started to stand out after the code was ported to use Shellbox.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PagedTiffHandler/+/754578/comment/bf6dc524_4b38318f/

Details

SubjectRepoBranchLines +/-
Drop unused PagedTiffHandlerRenderCommand hookmediawiki/extensions/PagedTiffHandlermaster+5 -10
Customize query in gerrit

Event Timeline

Krinkle created this task.Jan 19 2022, 11:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2022, 11:46 PM
gerritbot added a comment.Jan 28 2022, 4:16 PM

Change 757919 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/PagedTiffHandler@master] Drop unused PagedTiffHandlerRenderCommand hook

https://gerrit.wikimedia.org/r/757919

gerritbot added a project: Patch-For-Review.Jan 28 2022, 4:16 PM
gerritbot added a comment.Feb 23 2022, 8:42 PM

Change 757919 merged by jenkins-bot:

[mediawiki/extensions/PagedTiffHandler@master] Drop unused PagedTiffHandlerRenderCommand hook

https://gerrit.wikimedia.org/r/757919

Jdforrester-WMF closed this task as Resolved.Feb 23 2022, 8:44 PM
Jdforrester-WMF claimed this task.
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Feb 23 2022, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 23 2022, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL