Page MenuHomePhabricator

Notice: Undefined index: MustBeLoggedIn in SpecialContact.php on line 70
Closed, ResolvedPublic

Description

Setup

  • MediaWiki 1.35.5 (a1e5ae3) 07:44, 17. Jan. 2022
  • PHP 7.3.31-1~deb10u1 (apache2handler)
  • MariaDB 10.3.31-MariaDB-0+deb10u1
  • ContactPage 2.3 (df8ed9b) 06:53, 10. Jan. 2022

Issue
When accessing Special:Contact I get the following PHP Notice:

PHP Notice: Undefined index: MustBeLoggedIn in /../w/extensions/ContactPage/includes/SpecialContact.php on line 70

Event Timeline

Reedy triaged this task as Low priority.Jan 20 2022, 8:25 PM
Reedy added a subscriber: Reedy.

You should probably just set MustBeLoggedIn in your Contact config...

I'm guessing the config you've used was copied from the README? Which doesn't document MustBeLoggedIn (which we should fix).

Following up 1ae72a8dc4fcacb9151c2b7af87a2b456b2599e7

Change 755765 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@master] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/755765

You should probably just set MustBeLoggedIn in your Contact config...

I'm guessing the config you've used was copied from the README? Which doesn't document MustBeLoggedIn (which we should fix).

Following up 1ae72a8dc4fcacb9151c2b7af87a2b456b2599e7

Indeed, I was not ware that this should be added. My config predates 2016 and did not realize the change in the code nor on the extension's page. Senior moments. Thanks for updating the docu and tweaking the code! Much appreciated!

Change 755765 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/755765

Change 756574 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@REL1_37] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756574

Change 756575 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@REL1_36] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756575

Change 756576 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@REL1_35] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756576

Change 756574 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@REL1_37] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756574

Change 756575 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@REL1_36] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756575

Change 756576 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@REL1_35] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756576

Reedy claimed this task.

Fixed and backported