Notice: Undefined index: MustBeLoggedIn in SpecialContact.php on line 70
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Kghbln
	Jan 20 2022, 7:36 PM

Description

Setup

MediaWiki 1.35.5 (a1e5ae3) 07:44, 17. Jan. 2022
PHP 7.3.31-1~deb10u1 (apache2handler)
MariaDB 10.3.31-MariaDB-0+deb10u1
ContactPage 2.3 (df8ed9b) 06:53, 10. Jan. 2022

Issue
When accessing Special:Contact I get the following PHP Notice:

PHP Notice: Undefined index: MustBeLoggedIn in /../w/extensions/ContactPage/includes/SpecialContact.php on line 70

Details

Subject	Repo	Branch	Lines +/-
Document MustBeLoggedIn	mediawiki/extensions/ContactPage	REL1_35	+12 -8
Document MustBeLoggedIn	mediawiki/extensions/ContactPage	REL1_36	+12 -8
Document MustBeLoggedIn	mediawiki/extensions/ContactPage	master	+12 -8
Document MustBeLoggedIn	mediawiki/extensions/ContactPage	REL1_37	+12 -8

Customize query in gerrit

Related Objects

Mentioned In: rECPAa3207aef1f25: Document MustBeLoggedIn
rECPAc917327ca24c: Document MustBeLoggedIn
rECPA1a2cb18fec84: Document MustBeLoggedIn
rECPA745dc2141dcb: Document MustBeLoggedIn
Mentioned Here: rECPA1ae72a8dc4fc: Allow a contact page to require users to be logged in to use it
rECPAdf8ed9bcd4b5: Localisation updates from https://translatewiki.net.
rMWa1e5ae3cb0ca: Update git submodules

Event Timeline

Kghbln created this task.Jan 20 2022, 7:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2022, 7:36 PM

You should probably just set MustBeLoggedIn in your Contact config...

I'm guessing the config you've used was copied from the README? Which doesn't document MustBeLoggedIn (which we should fix).

Following up 1ae72a8dc4fcacb9151c2b7af87a2b456b2599e7

Change 755765 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@master] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/755765

gerritbot added a project: Patch-For-Review.Jan 20 2022, 8:28 PM

In T299689#7638212, @Reedy wrote:

You should probably just set MustBeLoggedIn in your Contact config...

I'm guessing the config you've used was copied from the README? Which doesn't document MustBeLoggedIn (which we should fix).

Following up 1ae72a8dc4fcacb9151c2b7af87a2b456b2599e7

Indeed, I was not ware that this should be added. My config predates 2016 and did not realize the change in the code nor on the extension's page. Senior moments. Thanks for updating the docu and tweaking the code! Much appreciated!

Change 755765 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/755765

Reedy mentioned this in rECPA745dc2141dcb: Document MustBeLoggedIn.Jan 24 2022, 4:45 PM

Change 756574 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@REL1_37] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756574

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.19; 2022-01-24).Jan 24 2022, 5:00 PM

Change 756575 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/ContactPage@REL1_36] Document MustBeLoggedIn

https://gerrit.wikimedia.org/r/756575

Change 756576 had a related patch set uploaded (by Reedy; author: Reedy):