Page MenuHomePhabricator
Create Task
Maniphest T300418

Improve Javascript test coverage to >=85% and enforce same for future patches
Closed, ResolvedPublic
Actions

Description

We would generally like to have >=85% coverage on lines, functions, branches, and statements in both Python and Javascript code. Current Javascript failure thresholds for coverage are set lower than this so that tests pass with legacy code with weak test coverage:

  • ✅ lines: 85
  • ✅ functions: 85
  • branches: 75
  • ✅ statements: 85

Certain files like swagger.js and i18n/index.js have little to no test coverage.

Details

SubjectRepoBranchLines +/-
ui: Increase test coveragewikimedia/toolhubmain+66 -2
toolhub: Bump container version to 2022-03-15-002555-productionoperations/deployment-chartsmaster+1 -1
ui: Increase test coveragewikimedia/toolhubmain+524 -185
Customize query in gerrit

Event Timeline

Raymond_Ndibe created this task.Jan 29 2022, 12:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2022, 12:04 AM
bd808 renamed this task from Improve Test Coverage to Improve Javascript test coverage to >=85% and enforce same for future patches.Jan 29 2022, 12:11 AM
bd808 triaged this task as Medium priority.
bd808 updated the task description. (Show Details)
bd808 moved this task from Backlog to Groomed/Ready on the Toolhub board.
Reedy added a project: Test-Coverage.Jan 29 2022, 11:45 PM
Reedy updated the task description. (Show Details)
Raymond_Ndibe added a project: User-Raymond_Ndibe.Feb 2 2022, 4:58 AM
Raymond_Ndibe moved this task from Groomed/Ready to In Progress on the Toolhub board.
Raymond_Ndibe moved this task from Backlog to In Progress on the User-Raymond_Ndibe board.Feb 2 2022, 5:01 AM
Raymond_Ndibe added subscribers: Slst2020, bd808.Feb 7 2022, 3:33 PM

@bd808 and @Slst2020 our .vue files are currently exporting methods, but we are not testing any of those. What is our stand on this? since there are many of such functions, I think it makes sense to test those too. What does the team think about this?

bd808 added a comment.Feb 7 2022, 4:32 PM
In T300418#7689296, @Raymond_Ndibe wrote:

@bd808 and @Slst2020 our .vue files are currently exporting methods, but we are not testing any of those. What is our stand on this? since there are many of such functions, I think it makes sense to test those too. What does the team think about this?

I think it can make sense when there are methods in the .vue files which are actually contain testable business logic. I don't think there is a lot of value in testing methods that only add configuration (like data() or computed methods which are used for configuration) or trivially wrap a call to vuex.

bd808 moved this task from In Progress to Groomed/Ready on the Toolhub board.Feb 9 2022, 6:12 PM
gerritbot added a comment.Feb 26 2022, 12:46 AM

Change 766204 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] ui: Increase test coverage

https://gerrit.wikimedia.org/r/766204

gerritbot added a project: Patch-For-Review.Feb 26 2022, 12:46 AM
gerritbot added a comment.Feb 28 2022, 1:51 PM

Change 766204 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Increase test coverage

https://gerrit.wikimedia.org/r/766204

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2022, 2:11 PM
bd808 updated the task description. (Show Details)Feb 28 2022, 4:35 PM
Raymond_Ndibe moved this task from In Progress to Backlog on the User-Raymond_Ndibe board.Mar 9 2022, 2:35 PM
gerritbot added a comment.Mar 15 2022, 12:34 AM

Change 770638 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

gerritbot added a project: Patch-For-Review.Mar 15 2022, 12:34 AM
gerritbot added a comment.Mar 15 2022, 4:51 PM

Change 770638 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

Maintenance_bot removed a project: Patch-For-Review.Mar 15 2022, 5:17 PM
gerritbot added a comment.Dec 1 2022, 3:58 AM

Change 862407 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] ui: Increase test coverage

https://gerrit.wikimedia.org/r/862407

gerritbot added a project: Patch-For-Review.Dec 1 2022, 3:58 AM
bd808 changed the task status from Open to In Progress.Dec 1 2022, 3:59 AM
bd808 claimed this task.
bd808 moved this task from Groomed/Ready to Review on the Toolhub board.
Restricted Application added a project: User-bd808. · View Herald TranscriptDec 1 2022, 3:59 AM
gerritbot added a comment.Dec 5 2022, 5:05 PM

Change 862407 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Increase test coverage

https://gerrit.wikimedia.org/r/862407

Maintenance_bot removed a project: Patch-For-Review.Dec 5 2022, 5:30 PM
bd808 closed this task as Resolved.Dec 15 2022, 11:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL