Recursively Compare Objects to Assess Equality
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Feb 1 2022, 5:00 PM

Description

deepEqual (javascript/src/utils.js) currently compares the string representation of objects. This can break in many ways. deepEqual should instead use a library which properly implements deep equality logic (or we can write our own ... ).

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222	operations/deployment-charts	master	+2 -2
wikifunctions: Upgrade orchestrator from 2024-01-18-182456 to 2024-02-12-155846	operations/deployment-charts	master	+1 -1
Update function-schemata sub-module to HEAD (1cd351c)	mediawiki/extensions/WikiLambda	master	+1 -1

Customize query in gerrit

Related Changes in GitLab:

Title	Reference	Author	Source Branch	Dest Branch
Update function-schemata sub-module to HEAD (1cd351c)	repos/abstract-wiki/wikifunctions/function-orchestrator!133	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (1cd351c)	repos/abstract-wiki/wikifunctions/function-evaluator!157	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (1cd351c)	repos/abstract-wiki/wikifunctions/wikilambda-cli!29	jforrester	sync-function-schemata	main
Implement a reasonable deepEqual algorithm.	repos/abstract-wiki/wikifunctions/function-schemata!83	apine	apine-deep-equal	main

Customize query in GitLab

Related Objects

Mentioned In: rMSFEcadcf3ec5088: Update function-schemata sub-module to HEAD (1cd351c)

Event Timeline

cmassaro created this task.Feb 1 2022, 5:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2022, 5:00 PM

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:40 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:40 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:07 AM

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Feb 1 2024, 5:59 PM

cmassaro changed the task status from Open to In Progress.Feb 6 2024, 6:34 PM

cmassaro claimed this task.

cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

cmassaro removed cmassaro as the assignee of this task.Feb 6 2024, 6:49 PM

cmassaro moved this task from In Progress to Backlog on the Abstract Wikipedia team board.

cmassaro claimed this task.Feb 6 2024, 7:59 PM

cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/83

Draft: Implement a reasonable deepEqual algorithm.

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/83

Implement a reasonable deepEqual algorithm.

Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 4:31 PM

cmassaro moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Feb 8 2024, 6:28 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/29