Author: mdale
Description:
it appears that the upload wizard does not support uploading videos it errors out with "thumbnail missing information" Additionally the thumbnail check does nothing and proceeds to set the image src to null.
Version: unspecified
Severity: enhancement
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T38680 Upload Wizard release "elvis" (tracking) | |||
| Resolved | None | T29260 UploadWizard 1.0 (tracking) | |||
| Resolved | None | T30071 Upload wizard does gracefully handle no thumbnail errors |
mdale wrote:
Renamed title to reflect the error. The issue appears to be that the upload wizard has no error handling for when an asset is uploaded and it can't generate a thumbnail for that asset. http://commons.prototype.wikimedia.org/wiki/File:Working_menu.ogv for example uploads fine in the Special:Upload page, but dies in the Special:UploadWizard page
mdale wrote:
Neil were you able to get a better idea of what the issue was when we recreated it on prototype? I don't think it will be an issue for commons since it will have a working install of thumbnails. But it would be good to test before we deploy ;)
I think all you need to do for this bug is possibly double the size of thumbnail proxy, and possibly put a try catch around the asset load call.
neilk wrote:
(In reply to comment #3)
I think this is fixed as of r84730
To be clear:
Actually there *was* error handling if the thumbnail could not be generated. The server reports thumberror in that case.
In r84730 I fixed the case where the thumbnail URL is given to the client but it mysteriously 404s or has some other issue.
One reason could be the relatively low size allowed for thumbnails served via UploadStash; given how video previews currently work on MediaWiki it could be the case that 256K was not enough. Other people have asked for this limit to be raised, so I upped the maximum thumbnail size to 1MB in r84731.