Page MenuHomePhabricator
Create Task
Maniphest T301247

Special:NewItem doesn't correctly verify site ids
Closed, ResolvedPublicBUG REPORT
Actions

Description

Currently Special:NewItem only checks whether a given site is known, but not whether we're allowed to link it.

Special:NewItem should check that the target site exists and is an allowed link target, otherwise it should claim that the site isn't known.

Details

SubjectRepoBranchLines +/-
SpecialNewItem: Fix site validationmediawiki/extensions/Wikibasemaster+71 -18
Customize query in gerrit

Related Objects

Event Timeline

hoo created this task.Feb 8 2022, 1:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2022, 1:49 PM
hoo mentioned this in T284211: Uncaught TypeError: $(...).siteselector(...).getId is not a function.Feb 8 2022, 1:49 PM
gerritbot added a comment.Feb 8 2022, 1:50 PM

Change 760943 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Use a SiteLinkTargetProvider in SpecialNewItem

https://gerrit.wikimedia.org/r/760943

gerritbot added a project: Patch-For-Review.Feb 8 2022, 1:51 PM
hoo added a project: Wikidata-Campsite (Team A Hearth 🏰🔥).Feb 8 2022, 1:51 PM
hoo moved this task from Incoming to Peer Review on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
Maintenance_bot added a project: Wikidata.Feb 8 2022, 2:45 PM
gerritbot added a comment.Feb 9 2022, 12:40 PM

Change 760943 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] SpecialNewItem: Fix site validation

https://gerrit.wikimedia.org/r/760943

hoo moved this task from Peer Review to Product Verification on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.Feb 9 2022, 12:50 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 9 2022, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 9 2022, 1:10 PM
hoo mentioned this in T301904: Remove Wikidata sitelinks to invalid sites.Feb 16 2022, 6:57 PM
• Manuel closed this task as Resolved.Mar 29 2022, 9:59 AM
• Manuel claimed this task.
• Manuel moved this task from Product Verification to Our work done on the Wikidata-Campsite (Team A Hearth 🏰🔥) board.
• Manuel subscribed.

Tested this with @hoo. Done!

matej_suchanek mentioned this in T218028: Links to some wikis can be added to items but aren't displayed.May 15 2022, 11:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits