Maniphest T301684

Error on Beta when viewing infobox
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Tchanders
	Feb 14 2022, 4:19 PM

Tags

Referenced Files

	F34953077: Screen Shot 2022-02-15 at 11.54.12 PM.png
	Feb 16 2022, 4:55 AM

Subscribers

Description

This error appears on Beta when viewing the infobox on Special:Contributions: P20702

This is due to calling Object.keys on null, here.

The API returns null for proxyType when the Enterprise databases are unavailable, as on Beta. This should be handled in the infobox widget.

Details

	Subject	Repo	Branch	Lines +/-
	Allow for API returning null proxyType in infobox widget	mediawiki/extensions/IPInfo	master	+19 -17

Customize query in gerrit

Related Objects

Mentioned Here: P20702 IPInfo infobox error on beta

Event Timeline

• Tchanders created this task.Feb 14 2022, 4:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2022, 4:19 PM

Change 762473 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/IPInfo@master] Allow for API returning null proxyType in infobox widget

https://gerrit.wikimedia.org/r/762473

gerritbot added a project: Patch-For-Review.Feb 14 2022, 4:20 PM

• Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Feb 14 2022, 4:26 PM

Change 762473 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Allow for API returning null proxyType in infobox widget

https://gerrit.wikimedia.org/r/762473

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.22; 2022-02-14).Feb 15 2022, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2022, 12:10 AM

• Tchanders claimed this task.Feb 15 2022, 3:04 AM

• Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.

• imaigwilo moved this task from QA/Testing 🐞 to Done: Q2 2021-22 on the Anti-Harassment (The Letter Song) board.Feb 16 2022, 4:48 AM

no major error showing as previously:

Screen Shot 2022-02-15 at 11.54.12 PM.png (1×2 px, 416 KB)

Niharika closed this task as Resolved.Feb 17 2022, 1:33 AM

Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 7:58 PM