Page MenuHomePhabricator

Sticky header dropdown has items it shouldn't have
Closed, ResolvedPublicBUG REPORT

Description

The sticky header dropdown is supposed to be a separate menu from the user menu. Gadgets can add to it, but adding to the standard user dropdown menu does not imply it should be also added to the sticky header

As a result, while rare gadgets such as the clock gadget can show up in the sticky header under certain slower loading conditions.

TODO

  • Add a test
  • Fix the problem.

Event Timeline

Change 763782 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Sticky header dropdown should not contain gadgets in personal menu

https://gerrit.wikimedia.org/r/763782

Change 763782 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Sticky header dropdown should not contain gadgets in personal menu

https://gerrit.wikimedia.org/r/763782

Jdlrobson claimed this task.

Verified on the beta cluster: When I run mw.util.addPortletLink ('p-personal', '#', 'text', 'foo' ) the link is adding to the user menu but not sticky header.