Page MenuHomePhabricator
Create Task
Maniphest T302269

Deletion reasons on Special:PageTranslationDeletePage doesn't parse magic words
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

The dropdown reasons on PageTranslationDeletePage special page doesn't work with switch
Maybe rETRA1699ff877523c738e4387b1208fcd7ba084a6cdf broke something?

massdel.png (858×1 px, 73 KB)

Details

SubjectRepoBranchLines +/-
Parse magic words in deletereason-dropdown messagemediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Stryn created this task.Feb 22 2022, 11:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2022, 11:33 AM
Nikerabbit triaged this task as Medium priority.Feb 28 2022, 11:32 AM
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
Nikerabbit changed the subtype of this task from "Task" to "Bug Report".
Nikerabbit claimed this task.Mar 1 2022, 2:28 PM
Nikerabbit added projects: Language-Team (Language-2022-January-March), Unplanned-Sprint-Work.
Nikerabbit set the point value for this task to 1.
Nikerabbit moved this task from Quarter Backlog to Priority: Localization infrastructure on the Language-Team (Language-2022-January-March) board.

Trivial plain() -> text() change. Waiting until the class is renamed though.

Nikerabbit renamed this task from Deletion reasons on Special:PageTranslationDeletePage doesn't accept switch to Deletion reasons on Special:PageTranslationDeletePage doesn't parse magic words.Mar 1 2022, 2:30 PM
gerritbot added a comment.Mar 2 2022, 10:37 AM

Change 767480 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Parse magic words in deletereason-dropdown message

https://gerrit.wikimedia.org/r/767480

gerritbot added a project: Patch-For-Review.Mar 2 2022, 10:37 AM
Nikerabbit moved this task from Priority: Localization infrastructure to In Review on the Language-Team (Language-2022-January-March) board.Mar 2 2022, 10:37 AM
gerritbot added a comment.Mar 7 2022, 8:47 AM

Change 767480 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Parse magic words in deletereason-dropdown message

https://gerrit.wikimedia.org/r/767480

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.25; 2022-03-07).Mar 7 2022, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 7 2022, 9:10 AM
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2022-January-March) board.Mar 7 2022, 10:21 AM
Nikerabbit added a comment.Mar 10 2022, 12:23 PM

@Stryn I don't have rights to test deleting on Meta. Can you verify the fix?

Stryn added a comment.Mar 10 2022, 12:40 PM
In T302269#7766850, @Nikerabbit wrote:

@Stryn I don't have rights to test deleting on Meta. Can you verify the fix?

Yes it works now. Thanks.

Nikerabbit closed this task as Resolved.Mar 10 2022, 1:51 PM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-January-March) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL