Page MenuHomePhabricator

Review API: "Move elasticsearch host usage to config #338"
Closed, ResolvedPublic

Description

During some of the previous ElasticSearch work we left the code reading env vars a little bit all over the place. This patch is a cleanup that rather than reading it everywhere we use the Config Facade instead of getenv.

AC

  • API PR 338 is either merged or closed.

Useful links:

https://github.com/wbstack/api/pull/338

Event Timeline

toan renamed this task from Review: Move elasticsearch host usage to config #338 to Review: "Move elasticsearch host usage to config #338".Feb 23 2022, 3:20 PM
toan renamed this task from Review: "Move elasticsearch host usage to config #338" to Review API: "Move elasticsearch host usage to config #338".Apr 5 2022, 7:22 AM
dang removed dang as the assignee of this task.EditedJun 22 2022, 3:11 PM
dang subscribed.

everything is ok. Please check again, if nothing is wrong I'm gonna merge and deploy it under new image tag.

dang updated the task description. (Show Details)