Fix ZErrorFactoryTest to not throw a PHP notice
Open, MediumPublic
Actions

Assigned To

None

Authored By

	Jdforrester-WMF
	Feb 24 2022, 6:18 PM

Description

00:01:27.747 Notice: Trying to get property 'failure' of non-object in /workspace/src/extensions/WikiLambda/tests/phpunit/integration/ZErrorFactoryTest.php on line 69
00:01:27.747 
00:01:27.747 Warning: Invalid argument supplied for foreach() in /workspace/src/extensions/WikiLambda/tests/phpunit/integration/ZErrorFactoryTest.php on line 69

Details

Subject	Repo	Branch	Lines +/-
wikifunctions: Upgrade evaluators from 2024-04-18-150843 to 2024-05-13-145650	operations/deployment-charts	master	+2 -2
ZErrorFactoryTest: Re-write to avoid DRY and make pass using post-2022 test format	mediawiki/extensions/WikiLambda	master	+46 -80
wikifunctions: Upgrade orchestrator 2024-04-04-132719 to 2024-04-17-125039	operations/deployment-charts	master	+1 -1
Update function-schemata sub-module to HEAD (5db8cea)	mediawiki/extensions/WikiLambda	master	+4 -8
Follow-up 0af102e5: Don't have ZErrorFactoryTest spam an error when doing nothing	mediawiki/extensions/WikiLambda	master	+1 -1

Customize query in gerrit

Title	Reference	Author	Source Branch	Dest Branch
Update function-schemata sub-module to HEAD (647a2cf)	repos/abstract-wiki/wikifunctions/wikilambda-cli!36	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (647a2cf)	repos/abstract-wiki/wikifunctions/function-evaluator!210	jforrester	sync-function-schemata	main
Update function-schemata sub-module to HEAD (5db8cea)	repos/abstract-wiki/wikifunctions/function-orchestrator!158	apine	sync-function-schemata	main
test_data/errors/canonical_Z2.yaml: Update PHP-expected errors for one case	repos/abstract-wiki/wikifunctions/function-schemata!109	jforrester	test-split-out	main

Customize query in GitLab

Event Timeline

Jdforrester-WMF created this task.Feb 24 2022, 6:18 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Mar 8 2022, 5:05 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Change 797337 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Follow-up 0af102e5: Switch ZErrorFactoryTest to use the 'new' structure of the test file

https://gerrit.wikimedia.org/r/797337

gerritbot added a project: Patch-For-Review.May 23 2022, 4:10 PM

Change 803266 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Follow-up 0af102e5: Don't have ZErrorFactoryTest spam an error when doing nothing

https://gerrit.wikimedia.org/r/803266

Change 803266 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Follow-up 0af102e5: Don't have ZErrorFactoryTest spam an error when doing nothing

https://gerrit.wikimedia.org/r/803266

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jun 6 2022, 10:00 PM

Jdforrester-WMF removed a project: MW-1.39-notes (1.39.0-wmf.15; 2022-06-06).Jul 25 2022, 1:19 PM

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:32 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:43 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Low priority.Mar 24 2023, 1:08 AM

Mcastro raised the priority of this task from Low to Medium.Apr 4 2024, 4:55 PM

Mcastro moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/109

test_data/errors/canonical_Z2.yaml: Update PHP-expected errors for one case

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/109

test_data/errors/canonical_Z2.yaml: Update PHP-expected errors for one case

Change #1016818 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5db8cea)

https://gerrit.wikimedia.org/r/1016818

Change #1016818 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5db8cea)

https://gerrit.wikimedia.org/r/1016818

Change #1020837 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator 2024-04-04-132719 to 2024-04-17-125039

https://gerrit.wikimedia.org/r/1020837

Change #1020837 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator 2024-04-04-132719 to 2024-04-17-125039

https://gerrit.wikimedia.org/r/1020837

Change #1031005 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-04-18-150843 to 2024-05-13-145650

https://gerrit.wikimedia.org/r/1031005

Change #1031005 merged by jenkins-bot: