check-vars.php doesn't work only in the given directory
Closed, InvalidPublic
Actions

Assigned To

Authored By

	Reedy
	Apr 1 2011, 11:59 PM

Description

reedy@ubuntu64-esxi:~/mediawiki/branches/REL1_17$ find phase3/ $ -name \*.php -or -name \*.inc $ -not $ -name importUseModWiki.php -o -name diffLanguage.php -o -name LocalSettings.php -o -name Parser?????.php $ -exec php ~/mediawiki/trunk/tools/code-utils/check-vars.php \{\} +

<snip>

Problems in phase3/includes/MessageCache.php:
Global variable $wgContLanguageCode is not present in DefaultSettings
Problems in /home/reedy/mediawiki/trunk/tools/code-utils/../../phase3maintenance/doMaintenance.php:
Did not found the expected require of /home/reedy/mediawiki/trunk/tools/code-utils/../../phase3AdminSettings.php

Errr, what?

I wanted it to target the REL1_17 branch, it seemed to use some of that, and some of trunk.

Halp?

Version: 1.17.x
Severity: minor

Details

Reference: bz28380

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:29 PM

• bzimport added a project: MediaWiki-General.

• bzimport set Reference to bz28380.

Reedy created this task.Apr 1 2011, 11:59 PM

I suppose what I'm asking for, is it to be pointed at a directory, and it work from there, not hard code back to a relative path to trunk phase3 :)

You can point to the proper phase3 with the MW_INSTALL_PATH environment variable.

The files could be in trunk/phase3, in extensions or in a release branch, so picking the right folder all times could be a bit tricky.

Note however that some featured used in REL1_17 are no longer taken into account in the trunk script (eg. it now checks for RUN_MAINTENANCE_IF_MAIN, not DO_MAINTENANCE). And not even trunk is completely free of warnings.

check-vars.php doesn't work only in the given directoryClosed, InvalidPublicActions

Description

Details

Event Timeline

check-vars.php doesn't work only in the given directory
Closed, InvalidPublic
Actions