Page MenuHomePhabricator

"Move subpages" setting not preserved on "destination page already exists" warning when moving pages
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to a page that has an extant subpage (e.g. en:User:Writ Keeper/sandbox, which has en:User:Writ Keeper/sandbox/test)
  • Go to move that page (e.g. https://en.wikipedia.org/wiki/Special:MovePage/User:Writ_Keeper/sandbox)
  • As the destination page, choose a page that already exists (e.g. User:Writ Keeper/sandbox2)
  • Uncheck the "Move subpages (up to 100)" box
  • Attempt to execute the move

What happens?:

You will receive a warning, momentarily stopping you from going further: "The destination page "User:Writ Keeper/sandbox2" already exists. Do you want to delete it to make way for the move? (Check the edit history.)" However, the "Move subpages (up to 100)" box will be checked again, despite us having unchecked it.

If we proceed with the move without noticing that this setting has been re-enabled, the subpage moves will be executed, possibly leading to 100 unintended page moves.

What should have happened instead?:

The user's original choice for the "Move subpages" should be preserved after the warning. This would be consistent with the behavior of the "Move associated talk page" and "Leave a redirect behind" settings, which are preserved through the error.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
Browser: Firefox 95.0.2
Tests performed on production enwiki; also reproduced by User:Primefac

Event Timeline

Change 771472 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771472

+2'd so this will be fixed with the next train. Does this need a REL1_38 backport?

Change 771472 merged by jenkins-bot:

[mediawiki/core@master] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771472

Change 771402 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@REL1_38] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771402

Change 771403 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@REL1_37] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771403

Change 771404 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@REL1_36] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771404

Change 771405 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@REL1_35] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771405

In T304008#7785157, @Majavah wrote:

+2'd so this will be fixed with the next train. Does this need a REL1_38 backport?

Thanks! I cherry-picked it all the way back since it was introduced in 1.34 and pretty simple.

Change 771405 merged by jenkins-bot:

[mediawiki/core@REL1_35] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771405

Change 771404 merged by jenkins-bot:

[mediawiki/core@REL1_36] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771404

Change 771403 merged by jenkins-bot:

[mediawiki/core@REL1_37] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771403

Change 771402 merged by jenkins-bot:

[mediawiki/core@REL1_38] Don't re-check "Move subpages" on Special:MovePage after a warning

https://gerrit.wikimedia.org/r/771402