Page MenuHomePhabricator

Allow only specific users to review their own revisions
Closed, ResolvedPublic

Description

Patch to add codereview-review-own user right

Related to bug 27797

While reviewing your own code is bad practice, there are several instances I have run into on my instance of CodeReview where other people have checked code but not been bothered to mark it as OK in CodeReview.

This patch adds a new user right which by default is granted to only those in the svnadmins group. If the user has the right, it will let them mark their own revisions as OK like it did before bug 27797. If they don't, it won't have any effect on the current behaviour.

The expected use of this is to prevent users from marking their own revisions as OK, unless you're absolutely sure they already know this and won't ever mark their own revisions as OK without good reason.

This is a patch which I wrote specifically for my instance, but I'm submitting it here in case it's useful for someone else.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz28462

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:35 PM
bzimport set Reference to bz28462.
bzimport added a subscriber: Unknown Object (MLST).

r85668

Tweaked patch applied. Thanks!