image.py does not respect lower cased namepaces
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Xqt
	Apr 1 2022, 8:16 AM

Description

List of steps to reproduce (step by step, including full links if applicable):
pwb image Aktendulli.jpeg -site:wikipedia:de

What happens?:

Retrieving 1 pages from wikipedia:de.
No changes were necessary in [[Diskussion:Sprachgebrauch in der DDR/Archiv/1]]

1 pages read
0 pages written
0 pages skipped
Execution time: 1 seconds
Read operation time: 1.0 seconds
Script terminated successfully.

What should have happened instead?:

C:\pwb\GIT\core>pwb image Aktendulli.jpeg
Retrieving 1 pages from wikipedia:de.


>>> Diskussion:Sprachgebrauch in der DDR/Archiv/1 <<<
@@ -40 +40 @@
- Das ist ein Aktendulli [[bild:Aktendulli.jpeg]] [[Benutzer:Momomu|momomu]] 21:00, 15. Jan 2003 (CET)
+ Das ist ein Aktendulli  [[Benutzer:Momomu|momomu]] 21:00, 15. Jan 2003 (CET)

Do you want to accept these changes? ([y]es, [N]o, [e]dit original, edit
[l]atest, open in [b]rowser, [m]ore context, [a]ll, [q]uit):

Details

	Subject	Repo	Branch	Lines +/-
	[bugfix] Python 3.5 does not support inline flags inside groups	pywikibot/core	master	+16 -12
	[bugfix] Improve image regex	pywikibot/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T301908: Drop support for Python 3.5

Event Timeline

Xqt created this task.Apr 1 2022, 8:16 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptApr 1 2022, 8:16 AM

Xqt renamed this task from image.py does not respect lower cased namedpaces to image.py does not respect lower cased namepaces.Apr 1 2022, 8:17 AM

Xqt claimed this task.

Xqt triaged this task as High priority.

Change 776158 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Respect lowercased namespace with image.py

https://gerrit.wikimedia.org/r/776158

gerritbot added a project: Patch-For-Review.Apr 1 2022, 8:19 AM

Xqt added a subscriber: MarcoAurelio.Apr 1 2022, 8:24 AM

Change 776158 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Improve image regex

https://gerrit.wikimedia.org/r/776158

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2022, 6:11 PM

Xqt closed this task as Resolved.Apr 1 2022, 7:45 PM

Does not work with Python 3.5:
raise source.error("unknown flag", len(char))\r\nsre_constants.error: unknown flag at position 9\r\nCRITICAL: Exiting due to uncaught exception <class \'sre_constants.error\'>\r\n

Xqt mentioned this in T301908: Drop support for Python 3.5.Apr 4 2022, 5:07 AM

Change 777297 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Python 3.5 does not support inline flags inside groups

https://gerrit.wikimedia.org/r/777297

gerritbot added a project: Patch-For-Review.Apr 5 2022, 8:14 AM

Xqt closed this task as Resolved.Apr 5 2022, 9:11 AM

Change 777297 merged by jenkins-bot: