| jsn.sherman | |
| Apr 7 2022, 6:12 PM |
| F35104962: image.png | |
| May 7 2022, 12:48 AM |
| F35104960: image.png | |
| May 7 2022, 12:48 AM |
| F35105012: image.png | |
| May 7 2022, 12:48 AM |
| F35104978: image.png | |
| May 7 2022, 12:48 AM |
| F35104999: image.png | |
| May 7 2022, 12:48 AM |
| F35104958: image.png | |
| May 7 2022, 12:48 AM |
| F35104976: image.png | |
| May 7 2022, 12:48 AM |
| F35105009: image.png | |
| May 7 2022, 12:48 AM |
steps to reproduce
On a wiki (local, beta, or production) with a quicksurvey configured, set your language preference to an RTL language, such as Hebrew.
Navigate to a survey and note that the close button is displayed in the upper right hand corner of the survey panel; the same location as in LTR languages, such as English:
It should display in the upper-left corner instead, something like:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| QuickSurveys: Close button not flipped in RTL languages | mediawiki/extensions/QuickSurveys | master | +13 -5 |
Change 788718 had a related patch set uploaded (by Eigyan; author: Eigyan):
[mediawiki/extensions/QuickSurveys@master] [WIP]: Close button not flipped in RTL languages
WIP results
So far the code update is working as expected I will continue to test other survey configs and make sure the change is bullet-proof.
It was suggested in the engineering meeting, per @jsn.sherman , that I move the new htmlDirection prop higher up the DOM tree to effect the entire panel element rather than just the survey content and this change made it possible for the privacy policy to follow RTL properly. See screenshot below:
Change 788718 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] QuickSurveys: Close button not flipped in RTL languages
Using the following urls: https://en.wikipedia.beta.wmflabs.org/wiki/Apple?quicksurvey=true; https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Olomouck%C3%A9_tvar%C5%AF%C5%BEky&quicksurvey=T294363-1
I have verified when an RTL language (such as Hebrew) is displaying a survey, the X button (close button) is displaying in the upper-left corner of the survey.
@aminalhazwani:
Since there was a change to the survey layout I am passing this ticket to Design Review to get your final approval of the layout change for the X button, if it meets your approval you can pass this ticket to Product Sign Off.
Compatibility Testing was performed on the following:
Desktop – Chrome version 101 Windows 10 and 11 / Microsoft Edge version 101 Windows 10 and 11 / Firefox version 99 Windows 10 and 11 / Opera version 86 Windows 10 and 11 / Safari version 15.3 Mac OS Monterrey.
Mobile Devices – Android version 12 Samsung Galaxy S22 phone / Android version 4.4 Galaxy Tab 4 tablet / iOS version 15 iPad Pro 9th generation / iOS version 15.3 iPhone 13 Pro phone.
Below are screenshots of the X button change:
(NOTE: please disregard blurriness of screenshots, this is due to device simulation and is not related to the code change):
