Add `pyflakes` or Similar to Lint Test for Python Executor
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Apr 18 2022, 5:42 PM

Description

We currently don't have a mechanism for detecting unused code. We should. pyflakes is a good solution for this, but we can also consider alternatives, especially any code analyzers that also complain about long functions/classes that lack docstrings.

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222	operations/deployment-charts	master	+2 -2

Customize query in gerrit

	Title	Reference	Author	Source Branch	Dest Branch
	Add pyflakes to CI and fix associated errors:	repos/abstract-wiki/wikifunctions/function-evaluator!151	apine	apine-pyflakes	main

Customize query in GitLab

Event Timeline

cmassaro created this task.Apr 18 2022, 5:42 PM

Jdforrester-WMF added a project: function-evaluator.Apr 18 2022, 6:03 PM

Jdforrester-WMF added projects: Abstract Wikipedia Fix-It tasks, Technical-Debt.Apr 19 2022, 3:50 PM

Jdforrester-WMF moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Apr 19 2022, 4:23 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:48 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:30 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 12:43 AM

Jdforrester-WMF moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.Feb 1 2024, 5:55 PM

cmassaro claimed this task.Feb 6 2024, 6:36 PM

cmassaro changed the task status from Open to In Progress.Feb 6 2024, 6:46 PM

cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/151

Draft: Add pyflakes to CI and fix associated errors:

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/151

Add pyflakes to CI and fix associated errors:

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2024, 4:31 PM

cmassaro moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Feb 7 2024, 4:34 PM

Change 1002625 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

gerritbot added a project: Patch-For-Review.Feb 12 2024, 9:02 PM

Change 1002625 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-01-18-182630 to 2024-02-12-160222

https://gerrit.wikimedia.org/r/1002625

Jdforrester-WMF closed this task as Resolved.Feb 28 2024, 3:22 PM

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2024, 3:31 PM

Add `pyflakes` or Similar to Lint Test for Python ExecutorClosed, ResolvedPublicActions

Description

Details

Event Timeline

Add `pyflakes` or Similar to Lint Test for Python Executor
Closed, ResolvedPublic
Actions