Page MenuHomePhabricator

Tag disambiguator-link-added is wrongly added to move logs
Open, Needs TriagePublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The tag is added to a move log by the extension.

What should have happened instead?:
I think the tag should only be added to edits.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
1.39.0-wmf.7

Event Timeline

"Add a disambiguator-link-added tag" is a feature introduced in rEDISf687e2a5afa2b491ec37ffccb145a960df309127, and noticed this bug seems existed for a long time. We could check rc_log_type attribute in function onRecentChange_save and take no action if it is set.
A question is that I could not reproduce this bug every time when performing a move action, don't know why..

Change 787572 had a related patch set uploaded (by Stang; author: Stang):

[mediawiki/extensions/Disambiguator@master] Do not add disambiguator-link-added tag if is a logged action

https://gerrit.wikimedia.org/r/787572