List of steps to reproduce (step by step, including full links if applicable):
What happens?:
The tag is added to a move log by the extension.
What should have happened instead?:
I think the tag should only be added to edits.
Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc.:
1.39.0-wmf.7
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Do not add disambiguator-link-added tag if is a logged action | mediawiki/extensions/Disambiguator | master | +3 -0 |
"Add a disambiguator-link-added tag" is a feature introduced in rEDISf687e2a5afa2b491ec37ffccb145a960df309127, and noticed this bug seems existed for a long time. We could check rc_log_type attribute in function onRecentChange_save and take no action if it is set.
A question is that I could not reproduce this bug every time when performing a move action, don't know why..
Change 787572 had a related patch set uploaded (by Stang; author: Stang):
[mediawiki/extensions/Disambiguator@master] Do not add disambiguator-link-added tag if is a logged action
Change 787572 merged by jenkins-bot:
[mediawiki/extensions/Disambiguator@master] Do not add disambiguator-link-added tag if is a logged action
All should be all set when this departs the station next week. Thanks and apologies for the delay! I'm slightly temped to do a little post clean-up...
I said the same on the patch, but today I reliably reproduced by both (a) moving to a different namespace, and (b) don't leave a redirect. It could be just one of things. I'm not really sure.