Page MenuHomePhabricator

Volume control broken in ar.wp
Closed, ResolvedPublicBUG REPORT

Description

There is a hack in ar.wp Common.css: https://ar.wikipedia.org/w/index.php?title=CreativeCommon.css

video-js .vjs-volume-panel .vjs-volume-control.vjs-volume-vertical
left: -3000em

Example page: https://ar.wikipedia.org/wiki/بيرو?uselang=he
Click to play

Event Timeline

Change 788394 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Don't push volume slider off screen in rtl

https://gerrit.wikimedia.org/r/788394

I can. Do you want it now or later once the patch is merged and deployed?

You can do it now, it's already not working (it was for when we were still using an inline volume control, instead of a vertical one.)

Change 788394 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Don't push volume slider off screen in rtl

https://gerrit.wikimedia.org/r/788394

Looks good. should be fixed after next deploy cycle