Code copy pasted without attribution?
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	May 2 2022, 9:38 PM

Description

From what I can tell in https://gerrit.wikimedia.org/r/c/operations/software/thumbor-plugins/+/785127 (most of?) the code has been basically copy pasted from https://github.com/thumbor-community/core/tree/master/tc_core and the headers haven't been maintained.

# Copyright (c) 2017, thumbor-community

has been replaced with

# Copyright (c) 2022 Wikimedia Foundation

Technically AIUI the MIT license allows this, but it just feels poor practice to not attribute where it came from (in the commit summary, but it's too late for that), and it's hardly any effort to keep the original copyright lines, even if we then add our on own on top.

Details

	Subject	Repo	Branch	Lines +/-
	Update copyrights.	operations/software/thumbor-plugins	master	+5 -5

Customize query in gerrit

Related Objects

Mentioned In: rTHMBREXTb30f1594e051: Update copyrights.

Event Timeline

Reedy created this task.May 2 2022, 9:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2022, 9:38 PM

Reedy updated the task description. (Show Details)May 2 2022, 9:39 PM

Technically AIUI the MIT license allows this

If the code is a copy of the code from GitHub, then it doesn't. The MIT license... "only requiring preservation of copyright and license notices" (from https://choosealicense.com/licenses/mit/). In the actual license text the clause is "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

Oh, I see, I will update it. Thank you!

roman-stolar claimed this task.May 10 2022, 10:36 AM

roman-stolar moved this task from Backlog to To Do on the Thumbor Migration board.

roman-stolar moved this task from To Do to In Progress on the Thumbor Migration board.May 10 2022, 10:39 AM

Change 790645 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[operations/software/thumbor-plugins@master] Update copyrights.

https://gerrit.wikimedia.org/r/790645

gerritbot added a project: Patch-For-Review.May 10 2022, 10:54 AM

Change 790645 merged by jenkins-bot:

[operations/software/thumbor-plugins@master] Update copyrights.

https://gerrit.wikimedia.org/r/790645

roman-stolar mentioned this in rTHMBREXTb30f1594e051: Update copyrights..May 11 2022, 4:04 PM