Interaction between realtime preview and regular or live preview
Closed, DeclinedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	dom_walden
	May 3 2022, 4:02 PM

Description

What is the problem?

You can have regular/live preview ("Show preview") and realtime preview on at the same time. The HTML is more-or-less identical between them. Therefore, there may be conflicts of attributes like ids.

For example:

if you click an internal link in the realtime preview pane it will scroll to the section in the regular preview.
if you hide/show a TOC in the realtime preview pane it will hide/show in the regular preview (see screenshot).

and there are probably more.

Steps to reproduce problem

https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Mistrovstv%C3%AD_Evropy_v_judu_1963&action=edit
Click "Show preview"
Open realtime preview pane
In the realtime preview pane, click "hide" on the table of contents

Expected behavior: TOC in the realtime preview pane is hidden
Observed behavior: TOC in the regular preview is hidden

Screenshots

RTP_and_regular_preview.png (641×1 px, 52 KB)

Testing notes

The behaviour of regular preview and live preview can differ. It is worth testing them both.

Details

	Subject	Repo	Branch	Lines +/-
	Realtime preview: Hide wpPreviewWidget while open	mediawiki/extensions/WikiEditor	master	+8 -0

Customize query in gerrit

Event Timeline

dom_walden created this task.May 3 2022, 4:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2022, 4:02 PM

A suggestion — if the realtime previous pane is open, hide the "normal" preview button.

Change 799320 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/extensions/WikiEditor@master] Realtime preview: Hide wpPreviewWidget while open

https://gerrit.wikimedia.org/r/799320

gerritbot added a project: Patch-For-Review.May 25 2022, 12:09 PM

Hmm I think removing this functionality could have real consequences, esp for folks who are used to previewing from the regular flow and just want to check out RTP for a side by side quick check but want to see the full page in a full Show Preview context

I don't think this bug is that hazardous if the show preview and RTP differ a bit, it's okay in the end one is using the other for different purposes prehaps.

@dom_walden I think I am leaning to de-prioritizing this bug as a "P0" lmk if that brings up any concern.s

In T307475#7957955, @NRodriguez wrote:

Hmm I think removing this functionality could have real consequences, esp for folks who are used to previewing from the regular flow and just want to check out RTP for a side by side quick check but want to see the full page in a full Show Preview context

I don't think this bug is that hazardous if the show preview and RTP differ a bit, it's okay in the end one is using the other for different purposes prehaps.

@dom_walden I think I am leaning to de-prioritizing this bug as a "P0" lmk if that brings up any concern.s

Good points — I'm going to close out that WIP patch 😸

Change 799320 abandoned by Samtar:

[mediawiki/extensions/WikiEditor@master] Realtime preview: Hide wpPreviewWidget while open

Reason:

T307475#7957955

https://gerrit.wikimedia.org/r/799320

Maintenance_bot removed a project: Patch-For-Review.May 25 2022, 7:30 PM

• JMcLeod_WMF moved this task from New & TBD Tickets to Maintenance Backlog on the Community-Tech board.Jun 6 2022, 2:19 PM

• NRodriguez closed this task as Declined.Jul 20 2022, 12:43 PM

	F35175778: image.png
	May 25 2022, 11:50 AM

Interaction between realtime preview and regular or live previewClosed, DeclinedPublicBUG REPORTActions