Maniphest T308645

CirrusSearch should include GeoData in its phan analysis
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dcausse
	May 18 2022, 9:16 AM

Tags

Referenced Files

None

Subscribers

Description

GeoData depending on CirrusSearch we should make sure that any patches made to CirrusSearch does not break any functions used by GeoData and cause problems like T308640.
Adding GeoData as dependency of CirrusSearch while running phan in CI might help to catch this kind of issues.

AC:

CI fails a CirrusSearch patch if it's breaking GeoData

Details

	Subject	Repo	Branch	Lines +/-
	Include GeoData in CirrusSearch phan analysis	integration/config	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T308640: Error: Call to undefined method CirrusSearch\Connection::getPageType()

Event Timeline

dcausse created this task.May 18 2022, 9:16 AM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptMay 18 2022, 9:17 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 792997 had a related patch set uploaded (by DCausse; author: DCausse):

[integration/config@master] Include GeoData in CirrusSearch phan analysis

https://gerrit.wikimedia.org/r/792997

gerritbot added a project: Patch-For-Review.May 18 2022, 9:22 AM

dcausse claimed this task.May 18 2022, 9:22 AM

dcausse triaged this task as Medium priority.

dcausse edited projects, added Discovery-Search (Current work); removed Discovery-Search.

dcausse moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.

Change 792997 merged by jenkins-bot:

[integration/config@master] Include GeoData in CirrusSearch phan analysis

https://gerrit.wikimedia.org/r/792997

Maintenance_bot removed a project: Patch-For-Review.May 18 2022, 10:30 AM

Gehel moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 23 2022, 3:20 PM

Gehel closed this task as Resolved.May 30 2022, 9:33 AM