Page MenuHomePhabricator

Error: Call to undefined method CirrusSearch\Connection::getPageType()
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Call to undefined method CirrusSearch\Connection::getPageType()
exception.trace
from /srv/mediawiki/php-1.39.0-wmf.12/extensions/GeoData/includes/Searcher.php(51)
#0 /srv/mediawiki/php-1.39.0-wmf.12/extensions/GeoData/includes/Api/QueryGeoSearchElastic.php(126): GeoData\Searcher->performSearch(Elastica\Query, array, string)
#1 /srv/mediawiki/php-1.39.0-wmf.12/extensions/GeoData/includes/Api/QueryGeoSearch.php(51): GeoData\Api\QueryGeoSearchElastic->run()
#2 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiQuery.php(656): GeoData\Api\QueryGeoSearch->execute()
#3 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(1902): ApiQuery->execute()
#4 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(874): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.39.0-wmf.12/includes/api/ApiMain.php(845): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.39.0-wmf.12/api.php(90): ApiMain->execute()
#7 /srv/mediawiki/php-1.39.0-wmf.12/api.php(45): wfApiMain()
#8 /srv/mediawiki/w/api.php(3): require(string)
#9 {main}
Impact
Notes

After deploying to group1:

Details

Request URL
https://it.wikipedia.org/w/api.php?action=query&list=*&gsradius=*&format=*&gslimit=*&gscoord=*

Event Timeline

Cause is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/790734 removing this function but this patch should have had https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GeoData/+/790732 tagged as Depends-On.
We might have avoided this mistake by including GeoData in CirrusSearch phan analysis. I'll file a task to change this.

Ladsgroup claimed this task.
Ladsgroup triaged this task as Unbreak Now! priority.

I fixed the immediate problem by backporting the patch:

image.png (228×652 px, 18 KB)