Page MenuHomePhabricator
Create Task
Maniphest T310480

Keyboard navigation on SX language selector jumps two languages once
Closed, ResolvedPublicBUG REPORT
Actions

Description

Keyboard navigation using up or down keys on SX language selector jumps two languages once

Details

SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20220629mediawiki/extensions/ContentTranslationmaster+287 -73
Fix: Keyboard navigation on SX language selector jumps two languages oncemediawiki/extensions/ContentTranslationmaster+2 -2
Customize query in gerrit

Event Timeline

• santhosh created this task.Jun 13 2022, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 13 2022, 10:01 AM
gerritbot added a comment.Jun 13 2022, 10:08 AM

Change 805090 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] Fix: Keyboard navigation on SX language selector jumps two languages once

https://gerrit.wikimedia.org/r/805090

gerritbot added a project: Patch-For-Review.Jun 13 2022, 10:08 AM
• santhosh claimed this task.Jun 13 2022, 12:05 PM
• santhosh triaged this task as Low priority.
• santhosh added a project: Language-Team (Language-2022-April-June).
• santhosh moved this task from Quarter Backlog to In Review on the Language-Team (Language-2022-April-June) board.
gerritbot added a comment.Jun 16 2022, 8:36 AM

Change 805090 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix: Keyboard navigation on SX language selector jumps two languages once

https://gerrit.wikimedia.org/r/805090

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jun 16 2022, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 16 2022, 9:30 AM
• santhosh moved this task from In Review to Needs QA on the Language-Team (Language-2022-April-June) board.Jun 28 2022, 4:37 AM
gerritbot added a comment.Jun 29 2022, 9:54 AM

Change 809523 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220629

https://gerrit.wikimedia.org/r/809523

gerritbot added a project: Patch-For-Review.Jun 29 2022, 9:54 AM
gerritbot added a comment.Jun 29 2022, 1:04 PM

Change 809523 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20220629

https://gerrit.wikimedia.org/r/809523

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2022, 1:33 PM
Pginer-WMF edited projects, added Language-Team (Language-2022-July-September); removed Language-Team (Language-2022-April-June).Jul 4 2022, 10:55 AM
Pginer-WMF moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2022-July-September) board.
EChukwukere-WMF subscribed.Jul 20 2022, 2:40 AM

Testing status: QA PASS

Scenario 1: When the "Search for a language" field is empty

  • Scrolling through the languages is a one step process with the up and down arrow key navigation ( meaning it never jumps two steps)

Scenario 2: When the "Search for a language" field is filled with a search keyword like 'e'

  • Scrolling through the languages is a one step process with the up and down arrow key navigation ( meaning it never jumps two steps)
EChukwukere-WMF moved this task from Needs QA to Done on the Language-Team (Language-2022-July-September) board.Jul 20 2022, 2:41 AM
Pginer-WMF closed this task as Resolved.Jul 21 2022, 12:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL