Parsoid emits nothing rather than 0 when using {{NUMBERINGROUP:}} on a user group with no members
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Vahurzpu
	Jun 15 2022, 4:09 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Create a page including {{NUMBERINGROUP:group}} for some user group with no members. (such as this page on testwiki using push-subscription-manager or this one on enwiki using transwiki)
View the page normally
View the HTML through the API (sample one, sample two)

What happens?:

Where {{NUMBERINGROUP:group}} is in the wikitext, there is a span for the transclusion in the HTML, but it's empty

What should have happened instead?:

The HTML should contain a 0

Details

	Subject	Repo	Branch	Lines +/-
	Bump parsoid to 0.16.0-a13	mediawiki/vendor	master	+296 -259
	TemplateHandler: Check explicitly for an empty string	mediawiki/services/parsoid	master	+4 -4

Customize query in gerrit

Event Timeline

Vahurzpu created this task.Jun 15 2022, 4:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 15 2022, 4:09 AM

Change 805790 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] TemplaeHandler: Check explicitly for an empty string

https://gerrit.wikimedia.org/r/805790

gerritbot added a project: Patch-For-Review.Jun 15 2022, 11:51 AM

Interestingly enough, as part of work to run parser tests in Parsoid integrated mode, I was investigating related failures and this isolated bug made it easy for me to fix those. :)

ssastry triaged this task as Medium priority.Jun 15 2022, 11:51 AM

ssastry moved this task from Backlog to Code Review on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.

Change 805790 merged by jenkins-bot:

[mediawiki/services/parsoid@master] TemplateHandler: Check explicitly for an empty string

https://gerrit.wikimedia.org/r/805790

Maintenance_bot removed a project: Patch-For-Review.Jun 15 2022, 4:29 PM

ssastry moved this task from Code Review to To Verify on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.Jun 15 2022, 7:28 PM

ssastry moved this task from To Verify to To Deploy on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.

Change 806477 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.16.0-a13

https://gerrit.wikimedia.org/r/806477

gerritbot added a project: Patch-For-Review.Jun 17 2022, 9:15 PM