Warn about changing DBO_TRX via DBConnRef
Open, MediumPublic
Actions

Assigned To

None

Authored By

	aaron
	Jun 21 2022, 8:14 PM

Description

Only LoadBalancer can safely manage setting/clearing flags for LB-managed database handles.

Subject	Repo	Branch	Lines +/-
installer: remove redundant clearFlag( DBO_TRX )/commit() calls	mediawiki/core	master	+0 -5
jobqueue: remove JobQueueDB::getScopedNoTrxFlag() method	mediawiki/core	master	+3 -48
maintenance: remove Database::clearFlag() call in recompressTracked.php	mediawiki/core	master	+0 -1

Was this connected to a recent incident, or just a general defense in-depth idea?

Krinkle triaged this task as Medium priority.Jun 27 2022, 8:04 PM

Just general defense.

Krinkle unsubscribed.

Change #1059908 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] maintenance: remove Database::clearFlag() call in recompressTracked.php

Change #1060523 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] jobqueue: remove JobQueueDB::getScopedNoTrxFlag() method

Change #1060524 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] installer: remove redundant clearFlag( DBO_TRX )/commit() calls

Change #1059908 merged by jenkins-bot:

[mediawiki/core@master] maintenance: remove Database::clearFlag() call in recompressTracked.php

Change #1060523 merged by jenkins-bot:

[mediawiki/core@master] jobqueue: remove JobQueueDB::getScopedNoTrxFlag() method

Change #1060524 merged by jenkins-bot:

[mediawiki/core@master] installer: remove redundant clearFlag( DBO_TRX )/commit() calls