Page MenuHomePhabricator
Create Task
Maniphest T311307

Add debug logging for item terms storage after merging
Closed, ResolvedPublic
Actions

Description

In T309445, we are witnessing some strange behavior where the terms of an item aren’t properly updated after a merge. We want to find out whether the secondary data updates which are supposed to update the terms even take place, by adding some debug logging to ItemHandler::getSecondaryDataUpdates() and ItemTermStoreWriterAdapter::saveTermsOfEntity(). This should go to a separate channel (like e.g. the DuplicateParse channel), which would be configured to capture all debug messages. (By default, only messages at level ≥ info go to logstash.)

Details

SubjectRepoBranchLines +/-
Add debug logging for item term storagemediawiki/extensions/Wikibasemaster+46 -1
Add WikibaseTerms temporary debug log channeloperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 24 2022, 2:38 PM
Lucas_Werkmeister_WMDE mentioned this in T309445: [Investigation] Terms storage missing most item labels after merge, resulting in item IDs being shown.
Lucas_Werkmeister_WMDE claimed this task.Jun 27 2022, 9:19 AM
Lucas_Werkmeister_WMDE moved this task from To Do to Doing on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.
gerritbot added a comment.Jun 27 2022, 9:45 AM

Change 808836 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Add WikibaseTerms temporary debug log channel

https://gerrit.wikimedia.org/r/808836

gerritbot added a project: Patch-For-Review.Jun 27 2022, 9:45 AM

Change 808837 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add debug logging for item term storage

https://gerrit.wikimedia.org/r/808837

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 27 2022, 9:45 AM
gerritbot added a comment.Jun 27 2022, 1:25 PM

Change 808836 merged by jenkins-bot:

[operations/mediawiki-config@master] Add WikibaseTerms temporary debug log channel

https://gerrit.wikimedia.org/r/808836

Stashbot added a comment.Jun 27 2022, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2022-06-27T13:29:49Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:808836|Add WikibaseTerms temporary debug log channel (T311307)]] (duration: 03m 30s)

gerritbot added a comment.Jun 27 2022, 2:42 PM

Change 808837 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add debug logging for item term storage

https://gerrit.wikimedia.org/r/808837

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.18; 2022-06-27).Jun 27 2022, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 27 2022, 3:30 PM
Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 10) board.Jun 27 2022, 3:36 PM

Can be tech-verified (look for the new channel in logstash) once wmf.18 reaches Wikidata.

karapayneWMDE moved this task from Special:NewLexeme revival - sprint 10 to Special:NewLexeme revival - sprint 11 on the Special:NewLexeme revival board.Jun 28 2022, 9:08 AM
karapayneWMDE edited projects, added Special:NewLexeme revival (Special:NewLexeme revival - sprint 11); removed Special:NewLexeme revival (Special:NewLexeme revival - sprint 10).
karapayneWMDE moved this task from To Do to Test (Verification) on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.
Lucas_Werkmeister_WMDE mentioned this in T308071: 1.39.0-wmf.18 deployment blockers.Jun 28 2022, 12:54 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jun 30 2022, 11:41 AM
Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Special:NewLexeme revival (Special:NewLexeme revival - sprint 11) board.

The logging is working fine, see the mediawiki dashboard with the channel set to WikibaseTerms.

gerritbot added a comment.Jul 4 2022, 1:28 PM

Change 810921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add debug logging for term storage cleanup

https://gerrit.wikimedia.org/r/810921

gerritbot added a project: Patch-For-Review.Jul 4 2022, 1:28 PM
Lucas_Werkmeister_WMDE added a comment.Jul 4 2022, 3:29 PM
In T311307#8049035, @gerritbot wrote:

Change 810921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Add debug logging for term storage cleanup

https://gerrit.wikimedia.org/r/810921

Sorry, disregard, I meant to attach that to T309445. This task is done and should stay closed.

Lucas_Werkmeister_WMDE mentioned this in T313039: Remove debug logging for item terms storage after merging.Jul 14 2022, 2:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits