Maniphest T311998

`become` error message is confusing when using recursive memberships
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Sebastian_Berlin-WMSE
	Jul 4 2022, 10:54 AM

Description

List of steps to reproduce (step by step, including full links if applicable):

Go to tool admin page, e.g. https://toolsadmin.wikimedia.org/tools/id/isa-dev.
Click "manage maintainers".
Under "Tools" add a tool with maintainers, e.g. isa.
Click "Update".
As a user that is maintainer of the second tool ("isa"), SSH to toolforge and run become isa-dev.

What happens?:
Fails to "become" tool with error message:

You are not a member of the group tools.isa-dev.
Any existing member of the tool's group can add you to that.

What should have happened instead?:
"Becomes" tool.

Additional information
I created isa-dev and added isa as maintainer. @Eugene233 was the user tried and failed to "become" the tool.

Event Timeline

Sebastian_Berlin-WMSE created this task.Jul 4 2022, 10:54 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 4 2022, 10:54 AM

If tools.isa is a maintainer of tools.isa-dev, then you become isa as your user and then become isa-dev from isa.

jjmc89@tools-sgebastion-11:~$ become jjmc89-bot
tools.jjmc89-bot@tools-sgebastion-11:~> become jjmc89-bot-dev
tools.jjmc89-bot-dev@tools-sgebastion-11:~>

I see. I assumed it worked the same as if I added the maintainers of isa manually. If this is how it's intended to work I think it would be a good idea to clarify that on the maintainers page (toolsadmin.wikimedia.org/tools/id/.../maintainers/) and/or in the instructions for "become".

taavi renamed this task from Maintainers of tools added as maintainers can't use `become` to `become` error message is confusing when using recursive memberships.Dec 17 2022, 5:04 PM

`become` error message is confusing when using recursive membershipsOpen, Needs TriagePublicBUG REPORTActions

Description

Event Timeline

`become` error message is confusing when using recursive memberships
Open, Needs TriagePublicBUG REPORT
Actions