Page MenuHomePhabricator

api.Request.submit() wrongly tests result[key] to be a str
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

Run pwb wikibase_tests -v TestWikibaseParser of https://gerrit.wikimedia.org/r/c/pywikibot/core/+/297637

What happens?:

The test fails due to this assert statement in api.Request.submit() introduced in rPWBCd179b13:

assert isinstance(result[key], str), \
    'Unexpected {}: {!r}'.format(key, result[key])

but the result[key] is valid:

result[key] [{'raw': 'Not a quantity', 'error': 'ValueParsers\\ParseException', 'error-info': 'Malformed quantity', 'expected-format': 'quantity', 'messages': [{'name': 'wikibase-parse-error-quantity', 'parameters': [], 'html': {'*': 'Der Mengenwert ist ungültig.'}}]}] <class 'list'>
E

Event Timeline

Xqt triaged this task as High priority.
Xqt updated the task description. (Show Details)

Change 812520 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Remove assert statement in api.Request.submit()

https://gerrit.wikimedia.org/r/812520

Change 812520 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Remove assert statement in api.Request.submit()

https://gerrit.wikimedia.org/r/812520