Page MenuHomePhabricator

Make postgres/sqlite CI jobs voting in gate-submit for wmf-deployed extensions with abstract schema files
Open, Needs TriagePublic

Description

Analyse of dependency shows the following groups which could be enabled for voting postgres, when all extension of the group passed.

# Group one, db-extensions without dependency on other db-extensions
AntiSpoof          []
Babel              []
BetaFeatures       []
CentralAuth        []
CentralNotice      []
Cognate            []
CreditsSource      []
EntitySchema       []
FlaggedRevs        []
GlobalBlocking     []
GlobalPreferences  []
GlobalUsage        []
IPInfo             []
LdapAuthentication []
Linter             []
LiquidThreads      []
ORES               []
PageAssessments    []
ReadingLists       []
SecurePoll         []
ShortUrl           []
TimedMediaHandler  []
UrlShortener       []
WikiLambda         []
WikiLove           []


# Group two, db-extensions with dependency of db-extensions from the first group
CheckUser     [CentralAuth]
ProofreadPage [FlaggedRevs]
Translate     [FlaggedRevs]

# Group three, db-extensions with dependency of db-extensions from the previous groups and dependency on each other
AbuseFilter [             AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
Echo        [AbuseFilter, AntiSpoof, CentralAuth, CheckUser,       FlaggedRevs]

# Group four, db-extensions with dependency of db-extensions from the previous groups
BounceHandler      [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
ContentTranslation [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
DiscussionTools    [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs, Linter]
Flow               [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
Newsletter         [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
OATHAuth           [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
OAuth              [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]
PageTriage         [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs, ORES, WikiLove]
UploadWizard       [AbuseFilter, AntiSpoof, CentralAuth, CheckUser, Echo, FlaggedRevs]

# Group five, db-extensions with dependency of db-extensions from the previous groups and dependency on each other
GeoData                    [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs,          PropertySuggester, TimedMediaHandler, Wikibase, WikibaseQualityConstraints]
PropertySuggester          [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs, GeoData,                    TimedMediaHandler, Wikibase, WikibaseQualityConstraints]
Wikibase                   [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs, GeoData, PropertySuggester, TimedMediaHandler,           WikibaseQualityConstraints]
WikibaseQualityConstraints [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs, GeoData, PropertySuggester, TimedMediaHandler, Wikibase                            ]

# Group six, db-extensions with dependency of db-extensions from the previous groups
GrowthExperiments          [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs, Flow, GeoData, PropertySuggester, TimedMediaHandler, Wikibase, WikibaseQualityConstraints]
MachineVision              [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs,       GeoData, PropertySuggester, TimedMediaHandler, Wikibase, WikibaseQualityConstraints]
Math                       [AbuseFilter, AntiSpoof, BetaFeatures, CentralAuth, CheckUser, Echo, FlaggedRevs,       GeoData, PropertySuggester, TimedMediaHandler, Wikibase, WikibaseQualityConstraints]
OAuthRateLimiter           [AbuseFilter, AntiSpoof,               CentralAuth, CheckUser, Echo, FlaggedRevs, OAuth]

Test patch sets under https://gerrit.wikimedia.org/r/q/topic:check-experimental

Event Timeline

Getting the Flow tests working with postgres is a big challenge, beginning with schema, see T313552 and handling of escaping of the binary values etc.
Suggest to exclude that extension from the goal (and its dependency GrowthExperiments) with postgres. Sqlite works

Change 816049 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[integration/config@master] [zuul] Make postgres/sqlite voting for extension AbuseFilter

https://gerrit.wikimedia.org/r/816049

Change 816049 abandoned by Umherirrender:

[integration/config@master] [zuul] Make postgres/sqlite voting for extension AbuseFilter

Reason:

Needs more love on the test code

https://gerrit.wikimedia.org/r/816049

Dreamy_Jazz subscribed.

This being in place would have prevented a few recent issues with CheckUser. I'm always going to run check experimental for any change on CheckUser now.