Page MenuHomePhabricator
Create Task
Maniphest T313281

pagetriage-copyvio log entries don't appear in the replica databases
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue

What happens?:

  • 0 rows

What should have happened instead?:

  • 1000 rows

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

There's no reason I can think of to hide this information. It's publicly accessible at Special:Log under Potential copyright violation log. Was probably just a whitelist omission. Thanks to @Cryptic for the analysis.

The patch for this is probably to add - pagetriage-copyvio right here:

https://gerrit.wikimedia.org/g/operations/puppet/+/30ce51de11310f9771c7240d519d850ce4864cc2/modules/profile/templates/wmcs/db/wikireplicas/maintain-views.yaml#208

Details

SubjectRepoBranchLines +/-
maintain-views: Add pagetriage-copyvio to allowed logtypesoperations/puppetproduction+1 -0
Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Jul 19 2022, 1:41 AM
Restricted Application added a project: Infrastructure-Foundations. · View Herald TranscriptJul 19 2022, 1:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Novem_Linguae updated the task description. (Show Details)Jul 19 2022, 2:31 AM
Zabe edited projects, added Data-Services, Data-Engineering; removed Infrastructure-Foundations, Puppet.Jul 19 2022, 8:26 AM
Zabe added a project: cloud-services-team (Kanban).Jul 19 2022, 8:31 AM
Zabe subscribed.
gerritbot added a comment.Jul 19 2022, 8:33 AM

Change 815215 had a related patch set uploaded (by Zabe; author: Zabe):

[operations/puppet@production] maintain-views: Add pagetriage-copyvio to allowed logtypes

https://gerrit.wikimedia.org/r/815215

gerritbot added a project: Patch-For-Review.Jul 19 2022, 8:33 AM
Zabe moved this task from Backlog to Wiki replicas on the Data-Services board.Jul 19 2022, 8:36 AM
Novem_Linguae added a project: PageTriage.Jul 20 2022, 12:42 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 20 2022, 12:42 AM
Novem_Linguae moved this task from Backlog to Code Review on the PageTriage board.Jul 20 2022, 12:42 AM
Tgr moved this task from Inbox to Triaged on the Growth-Team board.Jul 27 2022, 3:29 AM
• EChetty moved this task from Incoming (new tickets) to Data Products & Metrics on the Data-Engineering board.Aug 1 2022, 1:09 PM
• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Aug 1 2022, 1:12 PM
• EChetty moved this task from Backlog to Ops Week on the Data-Engineering-Planning board.Aug 1 2022, 3:26 PM
TheresNoTime subscribed.Aug 5 2022, 4:13 PM
gerritbot added a comment.Aug 15 2022, 3:26 PM

Change 815215 merged by Btullis:

[operations/puppet@production] maintain-views: Add pagetriage-copyvio to allowed logtypes

https://gerrit.wikimedia.org/r/815215

BTullis claimed this task.Aug 15 2022, 3:26 PM
BTullis subscribed.

I have merged the change to the maintain-views script.

Maintenance_bot removed a project: Patch-For-Review.Aug 15 2022, 3:31 PM
Novem_Linguae moved this task from Code Review to Waiting for enwiki deploy on the PageTriage board.Aug 15 2022, 6:49 PM
BTullis added a comment.Aug 16 2022, 10:43 AM

I have now applied this change to the 'web' wikireplica service, by running the following command on each of clouddbd101[3-6]

sudo maintain-views --table logging --all-databases --replace-all

I had depooled these servers at the dbproxy layer, by switching the wikireplicas-b service from dbproxy1018 to dbproxy1019 temporarily.

I'll now repeat this operation on the 'analytics' wikireplicas service.

BTullis added a comment.Aug 16 2022, 11:50 AM

I have now run the script on the four 'analytics' wikireplicas, clouddb10[17-20]

...as well as the analytics db replica: clouddb1021

All servers have been repooled.

BTullis closed this task as Resolved.Aug 16 2022, 12:11 PM

I believe that this can now be resolved.

I forked the original query and re-ran it: https://quarry.wmcloud.org/query/66687

image.png (122×496 px, 13 KB)

Novem_Linguae awarded a token.Aug 16 2022, 12:14 PM
Novem_Linguae moved this task from Waiting for enwiki deploy to Done on the PageTriage board.Aug 31 2022, 9:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits