Page MenuHomePhabricator
Create Task
Maniphest T313336

GadgetUsage API results malformed when $wgSpecialGadgetUsageActiveUsers is enabled
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
"title": "Spezial:Badtitle/NS1346:gadget-Rechtschreibpruefung"
"title": "Especial:Badtitle/NS777:gadget-CorrectorOrtografico"

What should have happened instead?:
Not entirely sure, on enwiki it returns "title": "Gadget:gadget-Navigation popups". But Gadget: is no valid namespace on enwiki either me thinks. Valid namespace, unused though so arguably still wrong.

On other projects the value for "ns" is the number of active users. On enwiki it's always 2300. See also T120895.

Related Objects

Event Timeline

AlexisJazz created this task.Jul 19 2022, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 19 2022, 5:28 PM
AlexisJazz updated the task description. (Show Details)Jul 20 2022, 12:56 PM
SD0001 renamed this task from Badtitle in API results for qppage=GadgetUsage to GadgetUsage API results malformed when $wgSpecialGadgetUsageActiveUsers is enabled.Jul 21 2022, 4:52 AM
SD0001 subscribed.

This is occurring on wikis where $wgSpecialGadgetUsageActiveUsers is enabled. Gadget is a recognized namespace on all of these wikis.

AlexisJazz added a comment.Jul 21 2022, 8:55 AM

Odd that I missed that fact. As Wikimedia wikis don't set $wgGadgetsRepoClass to 'GadgetDefinitionNamespaceRepo' it's unused, but the namespace still exists.

AlexisJazz updated the task description. (Show Details)Jul 21 2022, 8:58 AM
AlexisJazz added a comment.Jul 25 2022, 7:16 AM

https://fi.wikisource.org/w/api.php?action=query&format=json&list=querypage&qppage=GadgetUsage&qplimit=max

For some reason fiwikisource doesn't have this issue.

Legoktm subscribed.Mar 4 2023, 6:01 AM

The reason it happens is because the database query needs to store two numbers, the # of enabled users and the # of active users. It abuses the namespace column for the number of active users; given those values are not real namespaces, we end up with Special:BadTitle.

See https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Gadgets/+/refs/heads/master/includes/SpecialGadgetUsage.php#113 and https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Gadgets/+/refs/heads/master/includes/SpecialGadgetUsage.php#195

AlexisJazz added a comment.Tue, Mar 19, 10:01 PM

Somebody changed it from 2300 to 8. See https://en.wikipedia.org/w/index.php?title=Wikipedia%3AVillage_pump_(technical)&oldid=1214586229#Gadget_being_used_by_-1_users

AlexisJazz added a comment.Wed, Mar 20, 10:59 AM

T354023 explains that, the Gadget: namespace has been removed globally.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL