Page MenuHomePhabricator

VisualEditor editnotice API doesn't set a page title when expanding user permission errors
Closed, ResolvedPublic

Description

The editnotice API doesn't pass a title object when expanding user permission errors, causing things like {{ROOTPAGENAME}} to fall back on (incorrect) $wgTitle defaults. An example of this can be seen at https://en.wikipedia.org/w/api.php?action=visualeditor&paction=metadata&page=User:Vahurzpu/common.js&uselang=en&formatversion=2 (search for "Badtitle/dummy title for API calls set in api.php"

This seems to have been a case missed by T300184, which corrected most similar cases

Event Timeline

Change 815426 had a related patch set uploaded (by Vahurzpu; author: Vahurzpu):

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: set title when expanding permission editnotices

https://gerrit.wikimedia.org/r/815426

Change 815426 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ApiVisualEditor: set title when expanding permission editnotices

https://gerrit.wikimedia.org/r/815426

matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
matmarex subscribed.

Thank you for the bug report and the fix!

The patch will be deployed to Wikimedia wikis next week, 26-28 July, per the usual schedule.

API response is now correct