Page MenuHomePhabricator

Cannot reload from error message until you change the wikitext
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

If reloading the preview pane leads to an error, you cannot reload again using the reload button.

For example, if a user temporarily loses network connection they may want to reload again after getting it back.

You have to make an edit to the wikitext first or press the reload shortcut key. But, there is nothing to indicate that a user needs to do this.

I think at some point we have made a change so that in manual-mode you cannot reload unless you have changed the wikitext. But, this makes less sense when you have an error.

Steps to reproduce problem
  1. Open an edit session (might help to be a big article like https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Cat&action=edit)
  2. Open the browsers devtools, go to the Network tab and change the throttle settings to be something slow (e.g. GPRS) or offline
  3. Reload the preview
  4. If the reload returns an error (i.e. because it timed out or has no connection), click the reload button (either in the error message or (if applicable) in the manual reload bar)

Expected behavior: Preview reloads
Observed behavior: Nothing happens

Environment

Browser: Firefox 91
Wiki(s): https://en.wikipedia.beta.wmflabs.org MediaWiki 1.39.0-alpha (50dfefb) 06:14, 20 July 2022.
Editor WikiEditor 0.5.3 (b49fe58) 06:19, 20 July 2022.

Event Timeline

Change 818097 had a related patch set uploaded (by Dmaza; author: Dmaza):

[mediawiki/extensions/WikiEditor@master] RealtimePreview: force update when reloading from error message

https://gerrit.wikimedia.org/r/818097

Change 818097 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] RealtimePreview: force update when reloading from error message

https://gerrit.wikimedia.org/r/818097

I can now reload from an error message using the reload button in the error message, even without changing the wikitext.

I tested in both auto- and manual-mode.

In manual-mode, I can only reload using the reload button in the error message (unless I change the wikitext, in which case I can use the shortcut).

In auto-mode, I can reload using the button or the shortcut.

Test environment: https://en.wikipedia.beta.wmflabs.org WikiEditor 0.5.3 (6ec8074) 12:27, 1 August 2022.
Test browsers: Firefox 91, Chromium 87.