CdxLookup pending bar animation does not clear if the text search does not return a result, or if you delete all characters
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Ddwaal
	Jul 20 2022, 3:02 PM

Description

Steps to replicate the issue (include links if applicable):
Type in the Lookup box, then delete all the characters.

What happens?:
On typing the box becomes animated, when you delete all the characters the animation stays.

What should have happened instead?:
On the box being empty again, the animation should disappear.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Example of bug in action in Wikifunctions: https://phabricator.wikimedia.org/T312115.

Details

Subject	Repo	Branch	Lines +/-
Update Codex from v0.1.0-alpha.10 to v0.1.1	mediawiki/core	master	+2 K -3 K
Lookup: When input is empty, clear pending state, and don't reopen menu	design/codex	main	+15 -1
Ensure the animated state on the CDX-Lookup box goes away if the input is empty.	mediawiki/extensions/WikiLambda	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: T312115: [BUG] CdxLookup animated state

Event Timeline

Ddwaal created this task.Jul 20 2022, 3:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2022, 3:02 PM

Ddwaal renamed this task from CdxLookup to CdxLookup: Animated State.Jul 20 2022, 3:02 PM

Volker_E renamed this task from CdxLookup: Animated State to Lookup: Animated State.Jul 21 2022, 12:24 PM

Jdforrester-WMF renamed this task from Lookup: Animated State to CdxLookup pending bar animation does not clear if the text search does not return a result, or if you delete all characters.Aug 1 2022, 6:52 PM

Jdforrester-WMF merged tasks: T312115: [BUG] CdxLookup animated state, T314262: Waiting bars do not clear if text search does not return a result .

Jdforrester-WMF added a project: Abstract Wikipedia team.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF added subscribers: • JKieserman, • OZhang-WMF, ori, Jdforrester-WMF.

Change 822092 had a related patch set uploaded (by Dani DW; author: Dani DW):

[mediawiki/extensions/WikiLambda@master] Ensure the animated state on the CDX-Lookup box goes away if the input is empty.

https://gerrit.wikimedia.org/r/822092

gerritbot added a project: Patch-For-Review.Aug 10 2022, 2:38 PM

Change 822092 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Ensure the animated state on the CDX-Lookup box goes away if the input is empty.

https://gerrit.wikimedia.org/r/822092

Jdforrester-WMF closed this task as Resolved.Aug 15 2022, 2:49 PM