Page MenuHomePhabricator
Create Task
Maniphest T314000

Swap "hidetoc" for "showtoc" in the ApiParse result
Open, Needs TriagePublic
Actions

Description

See parent task -- I decided to use the SHOW_TOC flag in ParserOutput instead of HIDE_TOC in order to support consistent ParserOutput flag merge semantics. So we need to transition the "hidetoc" property to "showtoc" before we release MW 1.39 and let this escape to the wild...

Details

SubjectRepoBranchLines +/-
Use ParserOutputFlags::SHOW_TOC in ApiParsemediawiki/coremaster+2 -1
ApiParse: remove deprecated 'hidetoc' propertymediawiki/coremaster+0 -2
ApiParse: transition 'hidetoc' to 'showtoc'mediawiki/coremaster+2 -0
ApiVisualEditorEdit: Transition from 'hidetoc' to 'showtoc' in API resultmediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpencscottT310083 ToC issues
 OpencscottT314000 Swap "hidetoc" for "showtoc" in the ApiParse result

Event Timeline

cscott created this task.Jul 27 2022, 10:32 PM
Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptJul 27 2022, 10:32 PM
gerritbot added a comment.Jul 27 2022, 10:37 PM

Change 804008 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Use ParserOutputFlags::SHOW_TOC in ApiParse

https://gerrit.wikimedia.org/r/804008

gerritbot added a project: Patch-For-Review.Jul 27 2022, 10:37 PM

Change 817909 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ApiParse: transition 'hidetoc' to 'showtoc'

https://gerrit.wikimedia.org/r/817909

gerritbot added a comment.Jul 27 2022, 10:40 PM

Change 817912 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Transition from 'hidetoc' to 'showtoc' in API result

https://gerrit.wikimedia.org/r/817912

gerritbot added a comment.Jul 28 2022, 3:17 PM

Change 818138 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] ApiParse: remove deprecated 'hidetoc' property

https://gerrit.wikimedia.org/r/818138

gerritbot added a comment.Jul 28 2022, 7:49 PM

Change 817909 merged by jenkins-bot:

[mediawiki/core@master] ApiParse: transition 'hidetoc' to 'showtoc'

https://gerrit.wikimedia.org/r/817909

gerritbot added a comment.Jul 28 2022, 7:49 PM

Change 817912 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] ApiVisualEditorEdit: Transition from 'hidetoc' to 'showtoc' in API result

https://gerrit.wikimedia.org/r/817912

ReleaseTaggerBot edited projects, added MW-1.39-notes (1.39.0-wmf.23; 2022-08-01); removed MW-1.39-notes (1.39.0-wmf.17; 2022-06-20).Jul 28 2022, 8:00 PM
gerritbot added a comment.Jul 28 2022, 9:54 PM

Change 818138 merged by jenkins-bot:

[mediawiki/core@master] ApiParse: remove deprecated 'hidetoc' property

https://gerrit.wikimedia.org/r/818138

gerritbot added a comment.Sep 9 2022, 9:49 PM

Change 804008 merged by jenkins-bot:

[mediawiki/core@master] Use ParserOutputFlags::SHOW_TOC in ApiParse

https://gerrit.wikimedia.org/r/804008

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.1; 2022-09-12).Sep 9 2022, 10:00 PM
Pppery removed a project: Patch-For-Review.Jun 14 2024, 6:23 PM
Pppery subscribed.

Anything left to do here?

Aklapper assigned this task to cscott.Jul 3 2024, 12:45 PM

@cscott: Could you please answer the last comment? Thanks in advance!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits