Page MenuHomePhabricator
Create Task
Maniphest T314100

Make insertId()/affectedRows() for upsert() and replace() consistent for sqlite/mysql/postgres
Closed, ResolvedPublic
Actions

Description

Mysql can might return 1 or 2 for a single row upsert (special mysql exception to distinguish update/create that predated RETURNING), whereas sqlite will return 1 (1 row updated or created).

I think the sqlite/postgres value makes more sense. With, REPLACE it is more defensible returning 2 since it is DELETE + INSERT, though that is not consistent with sqlite either.

Details

SubjectRepoBranchLines +/-
rdbms: make IDatabase::insertId() less fragile and more consistentmediawiki/coremaster+925 -93
rdbms: make affectedRows() count each updated row in replace() as onemediawiki/coremaster+4 -3
rdbms: make affectedRows() count each updated row in upsert() as onemediawiki/coremaster+3 -1
rdbms: simplify affectedRows() by using the QueryStatus resultmediawiki/coremaster+30 -49
Customize query in gerrit

Event Timeline

aaron created this task.Jul 28 2022, 11:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2022, 11:46 PM
gerritbot added a comment.Jul 29 2022, 7:12 AM

Change 818393 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: make insertId() and affectedRows() less fragile and more consistent

https://gerrit.wikimedia.org/r/818393

gerritbot added a project: Patch-For-Review.Jul 29 2022, 7:12 AM
Krinkle triaged this task as Medium priority.Aug 1 2022, 6:56 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
gerritbot added a comment.Aug 15 2022, 7:04 PM

Change 823204 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: make affectedRows() count each updated row in upsert() as one

https://gerrit.wikimedia.org/r/823204

gerritbot added a comment.Aug 15 2022, 7:04 PM

Change 823205 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: make affectedRows() count each updated row in replace() as one

https://gerrit.wikimedia.org/r/823205

aaron renamed this task from Make affectedRows() for upsert() and replace() consistent for sqlite/mysql/postgres to Make insertId()/affectedRows() for upsert() and replace() consistent for sqlite/mysql/postgres.Apr 24 2023, 4:36 PM
aaron moved this task from Backlog: Maintenance, non-prioritized to Doing: Goals on the Performance-Team board.Apr 26 2023, 7:27 PM
gerritbot added a comment.Apr 28 2023, 12:24 AM

Change 912353 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: simplify affectedRows() by using the QueryStatus result

https://gerrit.wikimedia.org/r/912353

gerritbot added a comment.Apr 29 2023, 5:32 PM

Change 912353 merged by jenkins-bot:

[mediawiki/core@master] rdbms: simplify affectedRows() by using the QueryStatus result

https://gerrit.wikimedia.org/r/912353

aaron claimed this task.May 1 2023, 7:16 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 3:01 AM
gerritbot added a comment.May 29 2023, 3:18 AM

Change 818393 merged by jenkins-bot:

[mediawiki/core@master] rdbms: make IDatabase::insertId() less fragile and more consistent

https://gerrit.wikimedia.org/r/818393

gerritbot added a comment.Jun 6 2023, 5:37 PM

Change 823204 merged by jenkins-bot:

[mediawiki/core@master] rdbms: make affectedRows() count each updated row in upsert() as one

https://gerrit.wikimedia.org/r/823204

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.13; 2023-06-13); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jun 6 2023, 6:00 PM
gerritbot added a comment.Jun 6 2023, 6:25 PM

Change 823205 merged by jenkins-bot:

[mediawiki/core@master] rdbms: make affectedRows() count each updated row in replace() as one

https://gerrit.wikimedia.org/r/823205

Maintenance_bot removed a project: Patch-For-Review.Jun 6 2023, 6:30 PM
aaron closed this task as Resolved.Jun 6 2023, 7:18 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL