Correct constructor calls in ZTypedMapTest.php
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	DMartin-WMF
	Aug 4 2022, 4:33 AM

Description

In ZTypedMapTest.php, there are several constructor calls like this:

new ZTypedList( ZTypedPair::buildType( 'Z6', 'Z40' ), ...

I believe it should be like this:

$elementType = ZTypedPair::buildType( 'Z6', 'Z40' );
new ZTypedList(ZTypedList::buildType( $elementType ), ...

Note: recently the first type of construct above caused a bug; changing it to the 2nd construct fixed the bug. See comments in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/815334

	Subject	Repo	Branch	Lines +/-
	ZTypedMapTest: Fix constructor calls; TypedList of TypedPair, not direct	mediawiki/extensions/WikiLambda	master	+10 -7

Change 820464 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZTypedMapTest: Fix constructor calls; TypedList of TypedPair, not direct

Change 820464 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZTypedMapTest: Fix constructor calls; TypedList of TypedPair, not direct