Page MenuHomePhabricator

DMartin-WMF (David Martin)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 6 2021, 1:16 AM (107 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
DMartin (WMF) [ Global Accounts ]

Recent Activity

Yesterday

DMartin-WMF renamed T352141: Metrics: Consider counting "About info" editing separately from Metrics: Consider counting "About elements" editing separately to Metrics: Consider counting "About info" editing separately.
Tue, Nov 28, 7:16 PM · WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF updated the task description for T352141: Metrics: Consider counting "About info" editing separately.
Tue, Nov 28, 7:11 PM · WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF renamed T352141: Metrics: Consider counting "About info" editing separately from Metrics: Consider counting "About elements" separately to Metrics: Consider counting "About elements" editing separately.
Tue, Nov 28, 7:07 PM · WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF changed the status of T292804: Use Z5s from function-schemata in Evaluators from Open to In Progress.
Tue, Nov 28, 5:59 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-evaluator
DMartin-WMF changed the status of T292804: Use Z5s from function-schemata in Evaluators, a subtask of T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator, from Open to In Progress.
Tue, Nov 28, 5:59 PM · Epic, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, function-evaluator, function-orchestrator
DMartin-WMF claimed T292804: Use Z5s from function-schemata in Evaluators.
Tue, Nov 28, 5:51 PM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-evaluator
DMartin-WMF created T352141: Metrics: Consider counting "About info" editing separately.
Tue, Nov 28, 6:47 AM · WikiLambda Front-end, Abstract Wikipedia team

Mon, Nov 27

DMartin-WMF closed T314927: Do not suppress root cause of errors as Resolved.

I had one last look through the code, everywhere that makeMappedResultEnvelope appears; didn't find any other places where an error is discarded.

Mon, Nov 27, 5:21 AM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF closed T314927: Do not suppress root cause of errors, a subtask of T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator, as Resolved.
Mon, Nov 27, 5:21 AM · Epic, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, function-evaluator, function-orchestrator

Thu, Nov 16

DMartin-WMF added a comment to T350497: Update the WikiLambda instrumentation to use core interaction events.

Hey @Jdforrester-WMF - Yes, I have a good idea what's involved, but also need some time to get the latest details and do some schema-creation. I've been anticipating this, but didn't think it would be time to do this until the new year. We could do it now, but I think it would unnecessarily disrupt my remaining H1-phase activities. I think it would make more sense to incorporate this into our team's H2 planning (for which I could write a brief PRD).

Thu, Nov 16, 8:36 PM · Abstract Wikipedia team, WikiLambda Front-end, Metrics Platform Backlog, Data Products
DMartin-WMF closed T287919: Audit ad Hoc Error Types in Orchestrator, a subtask of T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator, as Resolved.
Thu, Nov 16, 5:59 AM · Epic, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, function-evaluator, function-orchestrator
DMartin-WMF closed T287919: Audit ad Hoc Error Types in Orchestrator as Resolved.

This has been covered by work on T321115, T349784, T349785, and T350608.

Thu, Nov 16, 5:59 AM · Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF added a comment to T350066: WikiLambda metrics: Fix counting of edit-existing-object events.

Diagnosis: in the default view, clicking on the Edit tab does generate a wf.ui.defaultView.load event, but clicking on the pencil icon (for editing the About info) does not. In either case, one can eventually click on Publish (or Cancel), which always does generate the appropriate ...publish (or ...cancel) event.

Thu, Nov 16, 4:15 AM · Patch-For-Review, WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Wed, Nov 15

DMartin-WMF renamed T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones from Don't hard-code English-language error messages in the back-end; have pre-defined custom ones to Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Wed, Nov 15, 6:05 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator

Sat, Nov 11

DMartin-WMF updated the task description for T314927: Do not suppress root cause of errors.
Sat, Nov 11, 1:07 PM · Abstract Wikipedia team, function-orchestrator

Fri, Nov 10

DMartin-WMF added a comment to T314927: Do not suppress root cause of errors.

Regarding these 2 cases:

Fri, Nov 10, 9:37 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF updated the task description for T314927: Do not suppress root cause of errors.
Fri, Nov 10, 9:33 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF added projects to T351007: Consider adding key for 'function' or 'function call' to Z506 & Z517 : function-orchestrator, function-evaluator.
Fri, Nov 10, 9:31 PM · function-evaluator, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF updated the task description for T351007: Consider adding key for 'function' or 'function call' to Z506 & Z517 .
Fri, Nov 10, 9:30 PM · function-evaluator, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF created T351007: Consider adding key for 'function' or 'function call' to Z506 & Z517 .
Fri, Nov 10, 9:26 PM · function-evaluator, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF updated the task description for T314927: Do not suppress root cause of errors.
Fri, Nov 10, 5:56 PM · Abstract Wikipedia team, function-orchestrator

Thu, Nov 9

DMartin-WMF updated the task description for T314927: Do not suppress root cause of errors.
Thu, Nov 9, 12:48 AM · Abstract Wikipedia team, function-orchestrator

Wed, Nov 8

DMartin-WMF updated the task description for T314927: Do not suppress root cause of errors.
Wed, Nov 8, 5:05 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Wed, Nov 8, 3:29 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF closed T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones, a subtask of T321114: Don't create generic errors in the orchestrator, but specific custom ones, as Resolved.
Wed, Nov 8, 3:29 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF closed T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones as Resolved.

The remaining unchecked example in this ticket's description will be covered by T350608 (which is in progress). Closing.

Wed, Nov 8, 3:29 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator

Tue, Nov 7

DMartin-WMF reopened T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator) as "Open".

Reopening until the orchestrator error type has been used for the error mentioned in the description.

Tue, Nov 7, 5:09 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team
DMartin-WMF reopened T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator), a subtask of T321114: Don't create generic errors in the orchestrator, but specific custom ones, as Open.
Tue, Nov 7, 5:09 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF updated the task description for T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator).
Tue, Nov 7, 5:08 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team
DMartin-WMF renamed T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator) from Add error types: Reached recursion limit in orchestrator (evaluator) to Add and use error types: Reached recursion limit in orchestrator (evaluator).
Tue, Nov 7, 5:08 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team
DMartin-WMF closed T349784: Add error type for invalid evaluation result as Resolved.

Oops - now re-closing. We already have a ticket for using the new error type: T349785

Tue, Nov 7, 5:06 PM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF closed T349784: Add error type for invalid evaluation result, a subtask of T349785: Use error type for invalid evaluation result, as Resolved.
Tue, Nov 7, 5:05 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF renamed T349784: Add error type for invalid evaluation result from Add error type for invalid evaluation result, and use in the orchestrator to Add error type for invalid evaluation result.
Tue, Nov 7, 5:04 PM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF renamed T349784: Add error type for invalid evaluation result from Add error type for invalid evaluation result to Add error type for invalid evaluation result, and use in the orchestrator.
Tue, Nov 7, 4:37 PM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF reopened T349784: Add error type for invalid evaluation result as "Open".

Reopening until the new error type has been used in the orchestrator.

Tue, Nov 7, 4:36 PM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF reopened T349784: Add error type for invalid evaluation result, a subtask of T349785: Use error type for invalid evaluation result, as Open.
Tue, Nov 7, 4:36 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF claimed T349785: Use error type for invalid evaluation result.
Tue, Nov 7, 4:35 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF closed T349784: Add error type for invalid evaluation result as Resolved.
Tue, Nov 7, 4:34 PM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF closed T349784: Add error type for invalid evaluation result, a subtask of T349785: Use error type for invalid evaluation result, as Resolved.
Tue, Nov 7, 4:33 PM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF closed T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator) as Resolved.
Tue, Nov 7, 4:32 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team
DMartin-WMF closed T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator), a subtask of T321114: Don't create generic errors in the orchestrator, but specific custom ones, as Resolved.
Tue, Nov 7, 4:32 PM · Abstract Wikipedia team, function-orchestrator

Mon, Nov 6

DMartin-WMF added a subtask for T321114: Don't create generic errors in the orchestrator, but specific custom ones: T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator).
Mon, Nov 6, 5:53 PM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF added a parent task for T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator): T321114: Don't create generic errors in the orchestrator, but specific custom ones.
Mon, Nov 6, 5:53 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team
DMartin-WMF created T350608: Add and use error types: Reached recursion limit in orchestrator (evaluator).
Mon, Nov 6, 5:49 PM · Patch-For-Review, MW-1.42-notes (1.42.0-wmf.7; 2023-11-28), function-schemata, Abstract Wikipedia team

Tue, Oct 31

DMartin-WMF closed T348285: Wikifunctions Analytics: Display edits of existing implementations and tests as Resolved.

Closing this because the requested display changes have been completed. The noted count discrepancies will be addressed in T350066.

Tue, Oct 31, 6:57 PM · Product-Analytics (Kanban), Abstract Wikipedia team

Mon, Oct 30

DMartin-WMF created T350066: WikiLambda metrics: Fix counting of edit-existing-object events.
Mon, Oct 30, 5:22 PM · Patch-For-Review, WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Oct 26 2023

DMartin-WMF updated subscribers of T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.

@cmassaro , @Jdforrester-WMF :
All the occurrences listed above have been covered now by the patches, except for one:

Oct 26 2023, 7:31 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Oct 26 2023, 2:18 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Oct 26 2023, 2:08 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF added a subtask for T321114: Don't create generic errors in the orchestrator, but specific custom ones: T349785: Use error type for invalid evaluation result.
Oct 26 2023, 1:23 AM · Abstract Wikipedia team, function-orchestrator
DMartin-WMF added a parent task for T349785: Use error type for invalid evaluation result: T321114: Don't create generic errors in the orchestrator, but specific custom ones.
Oct 26 2023, 1:23 AM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF added a parent task for T349784: Add error type for invalid evaluation result: T349785: Use error type for invalid evaluation result.
Oct 26 2023, 1:19 AM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF added a subtask for T349785: Use error type for invalid evaluation result: T349784: Add error type for invalid evaluation result.
Oct 26 2023, 1:19 AM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF created T349785: Use error type for invalid evaluation result.
Oct 26 2023, 1:18 AM · Patch-For-Review, function-orchestrator, Abstract Wikipedia team
DMartin-WMF renamed T349784: Add error type for invalid evaluation result from function-schemata: add error type for invalid evaluation result to Add error type for invalid evaluation result.
Oct 26 2023, 1:14 AM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team
DMartin-WMF created T349784: Add error type for invalid evaluation result.
Oct 26 2023, 1:12 AM · Patch-For-Review, function-orchestrator, function-schemata, Abstract Wikipedia team

Oct 25 2023

DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Oct 25 2023, 4:53 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Oct 25 2023, 2:33 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator

Oct 16 2023

DMartin-WMF updated the task description for T349017: function-schemata: Audit use of Z99/Quote as type of errors.
Oct 16 2023, 6:56 PM · function-schemata, Abstract Wikipedia team
DMartin-WMF renamed T349026: function-schemata: Decide whether Z507's keys should be quoted & implement the decision from function-schemata: Determine whether Z507's keys should be quoted to function-schemata: Decide whether Z507's keys should be quoted & implement the decision.
Oct 16 2023, 6:55 PM · Abstract Wikipedia team, function-schemata
DMartin-WMF added a subtask for T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator: T349026: function-schemata: Decide whether Z507's keys should be quoted & implement the decision.
Oct 16 2023, 6:54 PM · Epic, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, function-evaluator, function-orchestrator
DMartin-WMF added a parent task for T349026: function-schemata: Decide whether Z507's keys should be quoted & implement the decision: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.
Oct 16 2023, 6:54 PM · Abstract Wikipedia team, function-schemata
DMartin-WMF created T349026: function-schemata: Decide whether Z507's keys should be quoted & implement the decision.
Oct 16 2023, 6:53 PM · Abstract Wikipedia team, function-schemata
DMartin-WMF added a subtask for T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator: T349017: function-schemata: Audit use of Z99/Quote as type of errors.
Oct 16 2023, 6:41 PM · Epic, Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, function-evaluator, function-orchestrator
DMartin-WMF added a parent task for T349017: function-schemata: Audit use of Z99/Quote as type of errors: T321113: Audit and update creation and manipulation of errors in the orchestrator and evaluator.
Oct 16 2023, 6:41 PM · function-schemata, Abstract Wikipedia team
DMartin-WMF updated the task description for T349017: function-schemata: Audit use of Z99/Quote as type of errors.
Oct 16 2023, 6:40 PM · function-schemata, Abstract Wikipedia team
DMartin-WMF created T349017: function-schemata: Audit use of Z99/Quote as type of errors.
Oct 16 2023, 5:44 PM · function-schemata, Abstract Wikipedia team

Oct 5 2023

DMartin-WMF added a project to T348285: Wikifunctions Analytics: Display edits of existing implementations and tests: Product-Analytics.
Oct 5 2023, 10:39 PM · Product-Analytics (Kanban), Abstract Wikipedia team
DMartin-WMF created T348285: Wikifunctions Analytics: Display edits of existing implementations and tests.
Oct 5 2023, 10:38 PM · Product-Analytics (Kanban), Abstract Wikipedia team

Oct 3 2023

DMartin-WMF updated the task description for T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones.
Oct 3 2023, 4:07 AM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF updated the task description for T347904: WikiLambda: Consider tracking function usage by other functions.
Oct 3 2023, 12:21 AM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Oct 2 2023

DMartin-WMF created T347904: WikiLambda: Consider tracking function usage by other functions.
Oct 2 2023, 7:22 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Oct 1 2023

DMartin-WMF created T347816: WikiLambda: Key label strings not displaying when key type is Z99.
Oct 1 2023, 8:07 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
DMartin-WMF closed T337354: Revisit the type of Z516's 'argument' key, a subtask of T321115: Don't hard-code English-language error messages in the orchestrator; have pre-defined custom ones, as Resolved.
Oct 1 2023, 7:39 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Patch-For-Review, Abstract Wikipedia team, Abstract Wikipedia Fix-It tasks, function-orchestrator
DMartin-WMF closed T337354: Revisit the type of Z516's 'argument' key as Resolved.
Oct 1 2023, 7:39 PM · function-schemata, function-orchestrator, Abstract Wikipedia team

Sep 28 2023

DMartin-WMF moved T335163: WikiLambdaApiBase: In logging, discriminate between different exceptions for executeFunctionCall from To triage: Nice-to-haves to Verify in production on the Abstract Wikipedia team board.
Sep 28 2023, 12:27 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, WikiLambda

Sep 27 2023

DMartin-WMF placed T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages up for grabs.
Sep 27 2023, 4:44 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF renamed T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages from [wikifunctions-wmf.26] Implementation Details popup - controls not clickable if the number of implementation is more than one to [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.
Sep 27 2023, 4:43 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team

Sep 26 2023

DMartin-WMF claimed T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.
Sep 26 2023, 2:22 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF added a comment to T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.

Right. It looks like the problem can occur when there are more than 2 "Details" pop-up links - either on a test page or an implementation page, but not on the Details tab of a function page..

Sep 26 2023, 1:39 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team

Sep 25 2023

DMartin-WMF added a project to T335163: WikiLambdaApiBase: In logging, discriminate between different exceptions for executeFunctionCall : Abstract Wikipedia Fix-It tasks.
Sep 25 2023, 5:22 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, WikiLambda
DMartin-WMF added a comment to T335163: WikiLambdaApiBase: In logging, discriminate between different exceptions for executeFunctionCall .

Not sure why I didn't specify the 3 different exceptions originally. Recently in production logs, I notice these 3 variants occurring, and I suspect the original observation motivating this ticket may have been the same:

Sep 25 2023, 5:21 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, Abstract Wikipedia team, WikiLambda
DMartin-WMF added a project to T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages: Abstract Wikipedia Fix-It tasks.
Sep 25 2023, 5:02 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF merged T347222: Can't close Details modal on Implementation page into T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.
Sep 25 2023, 4:57 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF merged task T347222: Can't close Details modal on Implementation page into T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.
Sep 25 2023, 4:57 AM · Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF added a comment to T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.

Note that the problem does not seem to occur on the Details tab of a function page, even if the tab has many Details links associated with its test runs. For example, try this on the Details tab of https://www.wikifunctions.org/view/en/Z10096

Sep 25 2023, 4:53 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team
DMartin-WMF added a comment to T346972: [wikifunctions-wmf.26] Details popup freezes on tester & implementation pages.

T347222 gives another example, and also mentions that the problem occurs on mobile. I'm closing T347222 as a duplicate.

Sep 25 2023, 4:50 AM · MW-1.41-notes (1.41.0-wmf.29; 2023-10-03), Abstract Wikipedia Fix-It tasks, WikiLambda Front-end, Abstract Wikipedia team

Sep 21 2023

DMartin-WMF added a comment to T342667: Wikifunctions Instrumentation Data QA.

@MNeisler - The same explanation applies to testers and implementations. In addition, refinements to the queries (for counting load events) are needed. These queries should check that the edit custom data property is true. (If it's false, that means the user is just viewing an existing tester or implementation, not creating.)

Sep 21 2023, 1:30 AM · Abstract Wikipedia team, Product-Analytics (Kanban)
DMartin-WMF added a comment to T342667: Wikifunctions Instrumentation Data QA.

@MNeisler noticed the following discrepancy: the number of function creation attempts is not equal to the sum of their publish and cancel events. However, upon investigation, this is not be expected. Here is the explanation, for functions:
WikiLambda method handleClickAway (Publish.vue) “Currently only handles navigation out when clicking a link”. So closing the tab, closing the tab’s window, or reusing by typing into the address bar, maybe even hitting the tab’s back button (?), do not generate a cancel event. Also, a tab could be left open indefinitely.

Sep 21 2023, 1:21 AM · Abstract Wikipedia team, Product-Analytics (Kanban)
DMartin-WMF added a comment to T342667: Wikifunctions Instrumentation Data QA.

The missing viewname values are now showing up, thanks to patch 955982.

Sep 21 2023, 1:11 AM · Abstract Wikipedia team, Product-Analytics (Kanban)

Sep 12 2023

DMartin-WMF updated the task description for T344030: Wikifunctions: Investigate the failure rate of function calls.
Sep 12 2023, 2:37 AM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
DMartin-WMF added a comment to T344030: Wikifunctions: Investigate the failure rate of function calls.

If I filter the events on our superset dashboard, September 1 through September 11, the percentage of successful execution goes up from 77.7 to 83.9. Still not a great number.

Sep 12 2023, 2:29 AM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
DMartin-WMF added a comment to T344030: Wikifunctions: Investigate the failure rate of function calls.

Looking at the WikiLambda debug channel on logstash, we currently have about 1500 instances of this exception in the last 30 days:

Sep 12 2023, 2:15 AM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team
DMartin-WMF closed T344033: WikiLambda: Investigate missing values of viewname for wf.ui.newView.mounted events as Resolved.

The patch above, 955982, addresses the problem.

Sep 12 2023, 1:59 AM · MW-1.41-notes (1.41.0-wmf.26; 2023-09-12), WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Aug 21 2023

DMartin-WMF placed T344030: Wikifunctions: Investigate the failure rate of function calls up for grabs.
Aug 21 2023, 4:09 PM · WikiLambda Front-end, WikiLambda, Abstract Wikipedia team

Aug 19 2023

DMartin-WMF added a watcher for AutosuggestSitelink: DMartin-WMF.
Aug 19 2023, 8:27 PM

Aug 18 2023

DMartin-WMF added a comment to T329506: User Facing Metrics Platform Documentation.

The collection of wikitech pages starting with Metrics_Platform is in good shape IMO.

Aug 18 2023, 12:15 AM · Data Products (Epics Timeline), Metrics Platform Backlog (Metrics Platform Kanban)
DMartin-WMF claimed T329508: Javascript Metrics Platform Documentation.
Aug 18 2023, 12:01 AM · Documentation, Metrics Platform Backlog
DMartin-WMF claimed T329510: Swift Metrics Platform Documentation.
Aug 18 2023, 12:00 AM · Documentation, Metrics Platform Backlog

Aug 17 2023

DMartin-WMF added a comment to T329510: Swift Metrics Platform Documentation.

We have a "mono-howto" at Metrics_Platform/Creating_An_Instrument, which will cover all 4 of the supported languages (but Swift is not currently covered).

Aug 17 2023, 11:59 PM · Documentation, Metrics Platform Backlog