Mon, Nov 27
I had one last look through the code, everywhere that makeMappedResultEnvelope appears; didn't find any other places where an error is discarded.
Thu, Nov 16
Hey @Jdforrester-WMF - Yes, I have a good idea what's involved, but also need some time to get the latest details and do some schema-creation. I've been anticipating this, but didn't think it would be time to do this until the new year. We could do it now, but I think it would unnecessarily disrupt my remaining H1-phase activities. I think it would make more sense to incorporate this into our team's H2 planning (for which I could write a brief PRD).
Diagnosis: in the default view, clicking on the Edit tab does generate a wf.ui.defaultView.load event, but clicking on the pencil icon (for editing the About info) does not. In either case, one can eventually click on Publish (or Cancel), which always does generate the appropriate ...publish (or ...cancel) event.
Wed, Nov 15
Sat, Nov 11
Fri, Nov 10
Regarding these 2 cases:
Thu, Nov 9
Wed, Nov 8
The remaining unchecked example in this ticket's description will be covered by T350608 (which is in progress). Closing.
Tue, Nov 7
Reopening until the orchestrator error type has been used for the error mentioned in the description.
Oops - now re-closing. We already have a ticket for using the new error type: T349785
Reopening until the new error type has been used in the orchestrator.
Mon, Nov 6
Tue, Oct 31
Closing this because the requested display changes have been completed. The noted count discrepancies will be addressed in T350066.
Mon, Oct 30
Oct 26 2023
Oct 25 2023
Oct 16 2023
Oct 5 2023
Oct 3 2023
Oct 2 2023
Oct 1 2023
Sep 28 2023
Sep 27 2023
Sep 26 2023
Right. It looks like the problem can occur when there are more than 2 "Details" pop-up links - either on a test page or an implementation page, but not on the Details tab of a function page..
Sep 25 2023
Not sure why I didn't specify the 3 different exceptions originally. Recently in production logs, I notice these 3 variants occurring, and I suspect the original observation motivating this ticket may have been the same:
Note that the problem does not seem to occur on the Details tab of a function page, even if the tab has many Details links associated with its test runs. For example, try this on the Details tab of https://www.wikifunctions.org/view/en/Z10096
Sep 21 2023
@MNeisler - The same explanation applies to testers and implementations. In addition, refinements to the queries (for counting load events) are needed. These queries should check that the edit custom data property is true. (If it's false, that means the user is just viewing an existing tester or implementation, not creating.)
@MNeisler noticed the following discrepancy: the number of function creation attempts is not equal to the sum of their publish and cancel events. However, upon investigation, this is not be expected. Here is the explanation, for functions:
WikiLambda method handleClickAway (Publish.vue) “Currently only handles navigation out when clicking a link”. So closing the tab, closing the tab’s window, or reusing by typing into the address bar, maybe even hitting the tab’s back button (?), do not generate a cancel event. Also, a tab could be left open indefinitely.
The missing viewname values are now showing up, thanks to patch 955982.
Sep 12 2023
If I filter the events on our superset dashboard, September 1 through September 11, the percentage of successful execution goes up from 77.7 to 83.9. Still not a great number.
Looking at the WikiLambda debug channel on logstash, we currently have about 1500 instances of this exception in the last 30 days:
The patch above, 955982, addresses the problem.
Aug 21 2023
Aug 19 2023
Aug 18 2023
The collection of wikitech pages starting with Metrics_Platform is in good shape IMO.