Page MenuHomePhabricator

jouncebot CI broken (flake8-logging-format plugin code does not match ^[A-Z]{1,3}[0-9]{0,3}$)
Closed, ResolvedPublic

Description

Seen on this change (CI console):

There was a critical error during execution of Flake8:
plugin code for `flake8-logging-format[logging-format]` does not match ^[A-Z]{1,3}[0-9]{0,3}$
ERROR: InvocationError for command /src/.tox/py37/bin/flake8 (exited with code 1)
___________________________________ summary ____________________________________
ERROR:   py37: commands failed

It seems like this error was fixed in the flake8-logging-format plugin with this commit, but I don’t see a new release for it on PyPI yet. We might have to pin an older Flake8 version in the meantime?

Event Timeline

(The pull request comments have some more details about the possibility of a new plugin release.)

pinning to flake8==4.0.1 resolves the issue

Change 820462 had a related patch set uploaded (by Samtar; author: Samtar):

[wikimedia/bots/jouncebot@master] requirements.txt: Pin flake8 to v4.0.1

https://gerrit.wikimedia.org/r/820462

Change 820462 merged by jenkins-bot:

[wikimedia/bots/jouncebot@master] requirements.txt: Pin flake8 to v4.0.1

https://gerrit.wikimedia.org/r/820462

Lucas_Werkmeister_WMDE changed the task status from Open to Stalled.Aug 5 2022, 10:18 AM

Resolved for now; let’s leave the task open for a while, to hopefully unpin Flake8 once there’s a new release of the plugin?

Change 868540 had a related patch set uploaded (by Majavah; author: Majavah):

[wikimedia/bots/jouncebot@master] Revert "requirements.txt: Pin flake8 to v4.0.1"

https://gerrit.wikimedia.org/r/868540

taavi changed the task status from Stalled to Open.Dec 17 2022, 5:02 PM

Change 868540 merged by jenkins-bot:

[wikimedia/bots/jouncebot@master] Revert "requirements.txt: Pin flake8 to v4.0.1"

https://gerrit.wikimedia.org/r/868540

taavi claimed this task.