| Dreamy_Jazz | |
| Aug 15 2022, 12:09 PM |
| F35453468: image.png | |
| Aug 15 2022, 12:09 PM |
Steps to replicate the issue (include links if applicable):
What happens?:
The title shows as '0' with a namespace.
What should have happened instead?:
There should be no title.
Software version (skip for WMF-hosted wikis like Wikipedia):
Checkuser on the master branch
Other information (browser name/version, screenshots, etc.):
var_export'ing the $row->cuc_title shows that the value is
'0'
Unless I've missed something in git blame, no recent enough patches have modified the code that CheckUser uses to render the title. I pulled in core a few days ago, but only noticed it now.
I've dived into this a bit more. My sqlite DB has the default for cuc_type as the string '0'. This is likely something left over before CheckUser used the abstract schema.
Okay. Because when I created this sqlite DB the schema was before the abstract schema, it used the mysql.sql file. This had the line for cuc_type:
cuc_type tinyint(3) unsigned NOT NULL default '0',
Therefore, when the value is not set the default in sqlite DBs is '0'. Code needs to be added to the Hooks.php file to address this. In the mean time and until the values can be fixed, the double equal signs are going to have to stay at least for sqlite unfortunately.
Change 823151 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):
[mediawiki/extensions/CheckUser@master] Revert some triple equal checks due to incompatabilities on sqlite
Change 823151 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Revert some triple equal checks due to incompatabilities on sqlite
The mediawiki database layer returns everything as string, even it is integer in the database.
You can do some strang things like done in other extensions to have strict equal: https://gerrit.wikimedia.org/g/mediawiki/extensions/ORES/+/3856dabbc6e6dd9a1f14487296deb31e635e6bd5/includes/Hooks/Api/ApiHooksHandler.php#209