To make phan stricter to catch more issues like T316575, also the parsoid repositiory should disable the following phan config (which make phan stricter)
// These are too spammy for now. TODO enable $cfg['null_casts_as_any_type'] = true; $cfg['scalar_implicit_cast'] = true;
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Bump parsoid to 0.17.0-a1 for MW 1.40 | mediawiki/vendor | master | +370 -102 | |
| Enable scalar_implict_cast phan checks | mediawiki/services/parsoid | master | +23 -17 |
Change 828091 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):
[mediawiki/services/parsoid@master] Enable scalar_implict_cast phan checks
Change 828091 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Enable scalar_implict_cast phan checks
Change 831602 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):
[mediawiki/vendor@master] Bump parsoid to 0.17.0-a1 for MW 1.40
Change 831602 merged by jenkins-bot:
[mediawiki/vendor@master] Bump parsoid to 0.17.0-a1 for MW 1.40
Removing $cfg['null_casts_as_any_type'] = true; is still a todo. It is still very spammy. Unassigning myself for now -- not planning to work on this anytime soon.