Page MenuHomePhabricator
Create Task
Maniphest T317032

Remove Diamond?
Closed, ResolvedPublic
Actions

Description

Diamond has been removed from production in 2019 and we stopped adding it to cloud images in October 2020 via https://gerrit.wikimedia.org/r/c/operations/puppet/+/632477
Since it was never ported to Python 3, it it also not available on Bullseye instances either; we have an OS check in profile::wmcs::instance for this.

There are also no remaining WMF-specific Diamond collectors in puppet anymore (these were all removed/replaced by Prometheus over the past years), as such Diamond only collects the base metrics provided by the diamond package itself (CPU/network/load/disk space/memory etc).

Is there any reason not to simply remove it for good? (By setting diamond::remove: true in Hiera for all of WMCS and eventually removing the Diamond puppet code)?

Details

SubjectRepoBranchLines +/-
Uninstall Diamond everywhereoperations/puppetproduction+17 -740
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedtaaviT336774 Current status of cloudmetrics and its components
 ResolvedtaaviT326266 Remove the WMCS statsd/Graphite service
 OpendcaroT313444 Streamline WMCS Alerting and Paging
 ResolvedtaaviT317032 Remove Diamond?
 ResolvedtaaviT264920 Grafana "cloud-vps-project-board" needs to be migrated from Graphite to Prometheus
 ResolvedtaaviT266050 Build Prometheus service for use by all Cloud VPS projects and their instances
 Resolved• JHeddenT250206 Deploy a proof of concept prometheus server in cloudvps to replace shinken
 Resolved• JHeddenT250210 Request creation of metricsinfra VPS project
 Resolved• BstormT252260 Try out removing the nfs client probes from the node exporter on VMs
 Resolvedbd808T256134 wikistats.analytics.eqiad.wmflabs blocking Prometheus scraping from metricsinfra
 ResolvedAndrewT128615 Get rid of Toolforge home page check from shinken
 DeclinedNoneT128716 Make icinga-wm report Tools homepage check at #wikimedia-cloud, too
 Resolved• nskaggsT284973 Request increased quota for metricsinfra Cloud VPS project
 ResolvedtaaviT285055 Allow project members/admins to ack/silence alerts of that project
 ResolvedjbondT286716 Create solution for developer account authentication for services hosted in Cloud VPS
 ResolvedtaaviT286301 Scale up metricsinfra prometheus beyond one Prometheus instance (Thanos/Cortex/similar)
 ResolvedtaaviT286335 Split metricsinfra alertmanager to separate hosts from prometheus
 ResolvedtaaviT287148 Set up IRC relay for metricsinfra alerts
 ResolvedtaaviT310799 Upgrade metricsinfra prometheus to bullseye
 ResolveddcaroT310802 Request increased quota for metricsinfra Cloud VPS project
 ResolvedAndrewT288108 Figure out how to deal with security groups when rolling out metricsinfra scraping

Event Timeline

MoritzMuehlenhoff created this task.Sep 5 2022, 12:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2022, 12:00 PM
Aklapper added projects: cloud-services-team, Technical-Debt.Dec 18 2022, 5:09 PM
Restricted Application edited projects, added cloud-services-team (Kanban); removed cloud-services-team. · View Herald TranscriptDec 18 2022, 5:09 PM
taavi edited projects, added Cloud-VPS; removed Cloud-Services.Dec 24 2022, 12:22 PM
taavi subscribed.Dec 24 2022, 12:25 PM

This could move forward today, I think. The basic instance metrics are now stored in Prometheus, although there isn't a replacement dashboard yet (T264920).

dcaro added a parent task: T313444: Streamline WMCS Alerting and Paging.Jan 3 2023, 11:19 AM
taavi added a subtask: T264920: Grafana "cloud-vps-project-board" needs to be migrated from Graphite to Prometheus.Jan 4 2023, 7:18 PM
taavi added a parent task: T326266: Remove the WMCS statsd/Graphite service.
fnegri edited projects, added cloud-services-team; removed cloud-services-team (Kanban).Jan 18 2023, 6:23 PM
fnegri moved this task from Kanban to Inbox on the cloud-services-team board.
taavi closed subtask T264920: Grafana "cloud-vps-project-board" needs to be migrated from Graphite to Prometheus as Resolved.May 7 2023, 1:17 PM
taavi mentioned this in T336774: Current status of cloudmetrics and its components.May 16 2023, 3:27 PM
taavi claimed this task.Jul 3 2023, 4:16 PM
gerritbot added a comment.Jul 3 2023, 4:28 PM

Change 935103 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/puppet@production] Uninstall Diamond everywhere

https://gerrit.wikimedia.org/r/935103

gerritbot added a project: Patch-For-Review.Jul 3 2023, 4:28 PM
gerritbot added a comment.Jul 17 2023, 12:39 PM

Change 935103 merged by Filippo Giunchedi:

[operations/puppet@production] Uninstall Diamond everywhere

https://gerrit.wikimedia.org/r/935103

Stashbot added a comment.Jul 17 2023, 12:45 PM

Mentioned in SAL (#wikimedia-cloud) [2023-07-17T12:45:45Z] <taavi> removing diamond from remaining buster instances T317032

Maintenance_bot removed a project: Patch-For-Review.Jul 17 2023, 1:12 PM
taavi closed this task as Resolved.Jul 17 2023, 1:15 PM

I'm going to call this done. The absent code is still there, but with so many instances with broken Puppet config I think we can just let it stay there until all of the buster instances have been removed.

fgiunchedi awarded a token.Jul 17 2023, 4:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits