Remove the code added to support migration from Diffusion to GitLab and code previously used to create and display Diffusion repos.
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T316295 Connect Striker created GitLab projects with Striker created Phabricator projects | ||
| Resolved | bd808 | T296893 Replace Diffusion integration with Gitlab integration in Striker (toolsadmin) | |||
| Declined | bd808 | T317272 Remove legacy Diffusion related code from Striker |
Event Timeline
Comment Actions
Now I am wondering if there is good value for the community in retaining some Diffusion functionality such that new gitlab repos also have a Diffusion mirror provisioned. This would primarily be useful for allowing folks to deep link to git commits with hashes here on Phabricator.
Comment Actions
[15:56] < bd808> brennen, thcipriani: I am now wondering if Striker should setup a Diffusion mirror for each gitlab repo it creates. This happened as a side effect for the repos I just migrated so there will be a feature gap growing for each new repo going forward. Github gives a much better (IMO) code browser than gitiles, but It can be really nice to be able to link to a git hash in Phabricator. Thoughts? [15:56] < bd808> Deciding on this would change my work for T317272 [15:56] < stashbot> T317272: Remove legacy Diffusion related code from Striker - https://phabricator.wikimedia.org/T317272 [16:14] <thcipriani> this was always mukundas argument for why differential should mirror everything. It is a really nice feature. I think having a mirror would make sense. [16:29] < brennen> thcipriani, bd808: concur with tyler. [16:31] < bd808> cool. that gives me a direction at least. It also makes me feel that I may have purged some data prematurely... but I can recreate it I think.